B-18326 Update the Estimated Weight - B-18327 Remove Fields - B-18322 Update Requested pickup date #11941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ual delivery date, and Required Delivery Date -Updated the Estimated Weight -Updated Requested pickup date
…t-PPM-Remove-select-fields-from-MTO-as-TOO-PPM
WeatherfordAaron
assigned WeatherfordAaron and JamesHawks224 and unassigned WeatherfordAaron
WeatherfordAaron
requested review from
deandreJones,
cameroncaci and
josiahzimmerman-caci
as code owners
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
KonstanceH
reviewed
Feb 6, 2024
|
Changes in this PR doesn't seem to match the PR to Integration. For example:
is in the PR to Integration but not on this one. |
|
test issue:
|
|
test issue: test step 4 failed. These fields show up on the MTO page |
|
testing issue: Step 4. No values show up in the MTO |
I checked the old branch against this branch and am not seeing a diff. Can you check one more time? |
|
Verification rpt attached. |
This was discussed through a DM in slack. Adding this comment as a reference. |
|
Per dev, main pr is correct and complete. |
…github.com/transcom/mymove into amw-B18326-Update-the-Estimated-Weight-PPM
KonstanceH
approved these changes
Feb 29, 2024
taeJungCaci
reviewed
Feb 29, 2024
Comment on lines
161
to
163
| weightResult = ppmShipment.estimatedWeight; | ||
| displayedPickupAddress = pickupAddress; | ||
| displayedDeliveryAddress = destinationAddress || destinationDutyLocationAddress; |
There was a problem hiding this comment.
Looks like you have duplicated changes. These lines are already in line 166~168
There was a problem hiding this comment.
Pushing that fix now. Thank you buddy
There was a problem hiding this comment.
No problem! But if those 3 lines of code are all there is in this PR, isn't that mean the changes are already in main and this PR is actually not needed?
There was a problem hiding this comment.
because I see 0 files changed now in this PR
The current state of the ask from the PO is not to have the 3 fields but rather to only have 2. The names are correct at this time AFAIK. |
WeatherfordAaron
deleted the
amw-B18326-Update-the-Estimated-Weight-PPM
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR into integration testing