Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flipt implementation #11971

Merged
merged 11 commits into from
Feb 9, 2024
Merged

Flipt implementation #11971

merged 11 commits into from
Feb 9, 2024

Conversation

cameroncaci
Copy link
Contributor

@cameroncaci cameroncaci commented Feb 9, 2024 •
edited
Loading

No Agility Ticket

Summary

  • Upped Flipt version from 1.26.1 to 1.36.0
  • Removed explicit declaration of envFetcher
  • Updated multi move router to be conditional from Flipt
  • Removed conditional rendering of multi move landing page, the router handles this for us
  • Added multi move Flipt fetcher to feature flag util
  • Removed multi move from experimental frontend const

Documentation

TODO, this PR will test a deployment to the loadtest environment. From here, documentation will be backfilled.

@cameroncaci cameroncaci changed the base branch from main to integrationTesting February 9, 2024 13:54
@robot-mymove
Copy link

robot-mymove commented Feb 9, 2024 •
edited
Loading

Warnings
⚠️

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?

View the frontend file org ADR for more information
⚠️ This PR does not include changes to unit tests, even though it affects app code.

Generated by 🚫 dangerJS against e1daeb5

@cameroncaci cameroncaci changed the base branch from integrationTesting to main February 9, 2024 16:40
@cameroncaci cameroncaci changed the base branch from main to integrationTesting February 9, 2024 16:47
@cameroncaci cameroncaci marked this pull request as ready for review February 9, 2024 16:47
@cameroncaci cameroncaci self-assigned this Feb 9, 2024
@cameroncaci cameroncaci merged commit 1ce06e5 into integrationTesting Feb 9, 2024
30 checks passed
@cameroncaci cameroncaci deleted the Flipt-Implementation branch February 9, 2024 19:44
@cameroncaci cameroncaci mentioned this pull request Feb 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deandreJones deandreJones deandreJones approved these changes

@TevinAdams TevinAdams TevinAdams approved these changes

@traskowskycaci traskowskycaci traskowskycaci approved these changes

@josiahzimmerman-caci josiahzimmerman-caci Awaiting requested review from josiahzimmerman-caci

@danieljordan-caci danieljordan-caci Awaiting requested review from danieljordan-caci

Assignees

@cameroncaci cameroncaci

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cameroncaci @robot-mymove @deandreJones @TevinAdams @traskowskycaci