B 17910 hal sc creates or modifies a shipment int

[landan-parker-0]

Agility B-17910

Summary

I have verified the items in the H&AL are correctly shown, and have added the downstream action of the closeout office added to the H&AL, as that is part of the flow for editing/creating a move for the SM.

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

(Playwright test for the SM creating a move and the SC getting to the H&AL page not included)

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting the MilMove application
• Instructions for running tests

How to test

1. Access the
2. Login as a service member
3. Create a ppm
4. Log in as SC
5. Navigate to the move that was newly created
6. Edit details of the move
7. Observe the changes populate properly in the audit history tab
8. Create a new PPM for the service member
9. Observe the changes populate in the audit history tab

Status: SUBMITTED

Pro-gear: Yes

Pro-gear weight: 245 lbs

Spouse pro-gear weight: 357 lbs

Estimated weight: 602 lbs

Expected departure date: 17 Feb 2024

Sit expected: Yes

SIT estimated storage start: 17 Feb 2024

SIT estimated storage end: 24 Feb 2024

SIT estimated storage weight: 526 lbs

Pickup postal code: 63653

Destination postal code: 29101

SIT location: DESTINATION

SIT estimated cost: $104.09

PPM estimated incentive: $22,603.25

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

The history fetcher sql file has changed
https://github.com/transcom/mymove/blob/2d9d1bbeb70cdb73a8283892c5265953b539e329/pkg/assets/sql_scripts/move_history_fetcher.sql

move_logs AS (
  SELECT
    audit_history.*,
    jsonb_agg(jsonb_strip_nulls(
      jsonb_build_object(
        'closeout_office_name',
        (SELECT transportation_offices.name FROM transportation_offices WHERE transportation_offices.id = uuid(c.closeout_office_id))
      ))
    )::TEXT AS context,
    NULL AS context_id
  FROM
    audit_history
  JOIN move ON audit_history.object_id = move.id
  JOIN jsonb_to_record(audit_history.changed_data) as c(closeout_office_id TEXT) on TRUE
  WHERE audit_history.table_name = 'moves' group by audit_history.id
),

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots