B-18733 - MAIN - Prime Sim UI - Display Error Message Off response error #12039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ise because cannot hide button. Hiding will require schema change on GET response.
antgmann
approved these changes
Feb 22, 2024
r-mettler
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
NOTE: This PR does have changes from INT that are not in this main PR but this was because the INT PR was used to help resolve conflicts that were occurring between INT and main.
The only actual change for both PRs was made in the MoveDetails.jsx file and the changes match what is in INT.
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
r-mettler
deleted the
B-18733-Disable-Prime-Sim-Download-MoveOrder-Button-NonPrime
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-18733
E-04799
For MAIN
Summary
NOTE: This ticket is a result of an issue discovered during the PO acceptance demo for the EPIC (E-04799). On 422 Unprocessable Error users will now get a more accurate error message when a move does not have Prime counseling(only local counseling). Hiding the button is not feasible given the extra effort and potential risk because it required changing the GET response schema to return back the origin duty location hasCounseling flag.
This PR is for enhancements to the Prime Simulator UI to consume new Prime move order document download API.
GET: /moves/:locator/documents?type:typewhere:typecan be [ALL, ORDERS, AMENDMENTS]API is designed to handle the following use cases:
A new download button "Download Move Orders" and dropdown for doc type have been added within the Move section in the details page.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
Frontend
officeAppclass or custommin-widthstyling is used to hide any states the would not be visible to the user.