MAIN B-18313 Multi-Moves Profile Validation & Create a Move Btn Functionality #12041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljordan-caci
added
Mountain Movers
danieljordan-caci
requested review from
deandreJones,
TevinAdams,
cameroncaci and
traskowskycaci
danieljordan-caci
changed the title
|
Missing commit hashes from integration branches |
You're correct. I was getting some crazy errors and weird white space issues so it was easier just to fix the files themselves via copy/paste. |
For these MM PRs into
Tryin' my best here. |
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
traskowskycaci
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INTEGRATION PR
INTEGRATION PR - updates
Agility ticket
Summary
As we transition to allowing for multiple moves, we need to allow for the customer to validate their profile prior to starting a new move. If the service member does not have a previous move, then there's no need for them to validate their profile - technically it should already be current.
I went ahead and leveraged the
useLocationhook to pass around a state value (needsToVerifyProfile) when a user is validating their profile. At first I was usingsearchParamsbut it felt a little clunky and was a lot harder to test, so I transitioned to using localstateand passing thatstateto the relevant components.This PR does the following:
stateobject holding the current value ofneedsToVerifyProfileProfilecomponent, conditional rendering will occur of links and an alert bannerHow to test Scenario 1 (previous moves)
Create a MovebuttonCreate a Movebutton, andReturn to Dashboard(instead ofReturn to Move)Create a Movebutton and you'll be navigated to the current home pageHow to test Scenario 2 (no previous moves)
http://milmovelocal:3000/?moveData=noMovesinto the urlCreate a MovebuttonScreenshots