Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INT-B-18881 Add Search SC #12045

Merged
merged 32 commits into from
Feb 28, 2024
Merged

INT-B-18881 Add Search SC #12045

merged 32 commits into from
Feb 28, 2024

Conversation

loganwc
Copy link
Contributor

@loganwc loganwc commented Feb 23, 2024

Agility ticket

Summary

Adding search capability to the Services Counselors move queue.

How to test

  1. Access the Office app
  2. Login as a Services Counselor
  3. Click the Search tab
  4. Search for a move
  5. Click a move

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Screenshots

@loganwc loganwc self-assigned this Feb 23, 2024
@loganwc loganwc added G-Unit Scrum Team G INTEGRATION Slated for Integration Testing labels Feb 23, 2024
@loganwc loganwc marked this pull request as ready for review February 27, 2024 05:21
@loganwc loganwc requested a review from a team as a code owner February 27, 2024 05:21
@loganwc loganwc requested a review from deandreJones February 27, 2024 15:12
@loganwc
Copy link
Contributor Author

loganwc commented Feb 27, 2024

Requirements are being revisited, closing until they are clear.

@loganwc loganwc closed this Feb 27, 2024
@loganwc
fixed issue when filtering in search where you can't clear filters if…
7dad31f 
… there's no results, fixed pagination being blocked by QueryDevTools, added all statuses for SC search, cleaned up query for search
@loganwc
Merge branch 'B-18881-Add-search-SC' into INT-B-18881-Add-Search-SC
32f3965
@loganwc loganwc reopened this Feb 28, 2024
@loganwc loganwc merged commit 748f738 into integrationTesting Feb 28, 2024
30 checks passed
@loganwc loganwc deleted the INT-B-18881-Add-Search-SC branch February 28, 2024 21:51
@loganwc loganwc mentioned this pull request Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deandreJones deandreJones deandreJones left review comments

@paulstonebraker paulstonebraker paulstonebraker approved these changes

@pambecker pambecker pambecker approved these changes

@landan-parker-0 landan-parker-0 Awaiting requested review from landan-parker-0

@joeydoyecaci joeydoyecaci Awaiting requested review from joeydoyecaci

Assignees

@loganwc loganwc

Labels
G-Unit Scrum Team G INTEGRATION Slated for Integration Testing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@loganwc @deandreJones @paulstonebraker @pambecker