Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 18428 int #12049

Merged
merged 35 commits into from
Feb 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
fb510f1
Pulled main with merged SSW service, beginning work
antgmann Jan 18, 2024
b38cfb8
gen messages commit
antgmann Jan 18, 2024
4e96aa5
Working generation using truss PNG with added fields method
antgmann Jan 19, 2024
04a5eef
Page 3 of SSW removed
antgmann Jan 19, 2024
2bed124
PDF Template added
antgmann Jan 22, 2024
0616647
working template filling, creating SIT data
antgmann Jan 23, 2024
b102021
SIT Data added, committing for dev meeting
antgmann Jan 23, 2024
fe60059
Internal API is functional
antgmann Jan 23, 2024
d3ed730
looking at PRs
antgmann Jan 23, 2024
093ec2e
beginning unit tests
antgmann Jan 24, 2024
52e1358
Need assistance with final test function
antgmann Jan 24, 2024
f738675
Tests completed
antgmann Jan 24, 2024
9b35bc1
removed old template assets
antgmann Jan 31, 2024
e0fa6e4
abstraction to keep newTempFile private
antgmann Jan 31, 2024
575bc6d
properly import generator
antgmann Jan 31, 2024
b0422ed
define vars for reusability
antgmann Jan 31, 2024
10b4298
renamed generator function for reusability
antgmann Jan 31, 2024
8e068c8
move vars for function scoping
antgmann Jan 31, 2024
c75f6c1
refactor API to be in correct PPM tag and name
antgmann Feb 2, 2024
93b25ba
SSW File template opening potential fix
antgmann Feb 16, 2024
4d5b96f
Working fix for SSWTemplate
antgmann Feb 20, 2024
2566fa0
Peer review changes
antgmann Feb 21, 2024
dec709b
Merge main to update branch
antgmann Feb 21, 2024
fb94def
Added caching for template file, tested and functional with downstrea…
antgmann Feb 22, 2024
3f4daaa
Merge branch 'main' into E-04823-Tickets-B-18472-And-B-18457-MAIN
traskowskycaci Feb 22, 2024
e7c4019
Merge branch 'main' into E-04823-Tickets-B-18472-And-B-18457-MAIN
traskowskycaci Feb 22, 2024
e53c808
Merge with main before int branch
antgmann Feb 23, 2024
0814c2f
Merge branch 'B-18428-SSW-Form-PDF-Work' into B-18428-INT
antgmann Feb 23, 2024
94c7563
Merge branch 'main' into E-04823-Tickets-B-18472-And-B-18457-MAIN
traskowskycaci Feb 23, 2024
0a616ce
Merge branch 'main' into E-04823-Tickets-B-18472-And-B-18457-MAIN
traskowskycaci Feb 23, 2024
1de9c4e
Merge branch 'integrationTesting' into B-18428-INT
antgmann Feb 23, 2024
30276e0
Resolve conflicts with RankGrade refactor
antgmann Feb 23, 2024
13ce6f7
resolve merge conflicts with rank refactor
antgmann Feb 23, 2024
cfcbddf
Merge branch 'integrationTesting' into B-18428-INT
antgmann Feb 23, 2024
9d0f886
Merge branch 'integrationTesting' into B-18428-INT
antgmann Feb 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 8 additions & 46 deletions cmd/generate-shipment-summary/main.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package main

import (
"bytes"
"fmt"
"log"
"net/http"
Expand All @@ -16,7 +15,6 @@ import (
"go.uber.org/zap"

"github.com/transcom/mymove/pkg/appcontext"
"github.com/transcom/mymove/pkg/assets"
"github.com/transcom/mymove/pkg/auth"
"github.com/transcom/mymove/pkg/cli"
"github.com/transcom/mymove/pkg/logging"
Expand Down Expand Up @@ -59,7 +57,7 @@ func checkConfig(v *viper.Viper, logger *zap.Logger) error {
func initFlags(flag *pflag.FlagSet) {

// Scenario config
flag.String(PPMShipmentIDFlag, "", "The move ID to generate a shipment summary worksheet for")
flag.String(PPMShipmentIDFlag, "6d1d9d00-2e5e-4830-a3c1-5c21c951e9c1", "The PPMShipmentID to generate a shipment summary worksheet for")
flag.Bool(debugFlag, false, "show field debug output")

// DB Config
Expand Down Expand Up @@ -146,7 +144,7 @@ func main() {
testAppCode := os.Getenv("HERE_MAPS_APP_CODE")
hereClient := &http.Client{Timeout: hereRequestTimeout}

// TODO: Future cleanup will need to remap to a different planner, or this command should be removed if it is consider deprecated
// TODO: Future cleanup will need to remap to a different planner, but this command should remain for testing purposes
planner := route.NewHEREPlanner(hereClient, geocodeEndpoint, routingEndpoint, testAppID, testAppCode)
ppmComputer := shipmentsummaryworksheet.NewSSWPPMComputer()

Expand All @@ -159,49 +157,13 @@ func main() {
log.Fatalf("%s", errors.Wrap(err, "Error calculating obligations "))
}

page1Data, page2Data, page3Data := ppmComputer.FormatValuesShipmentSummaryWorksheet(*ssfd)
page1Data, page2Data := ppmComputer.FormatValuesShipmentSummaryWorksheet(*ssfd)
noErr(err)

// page 1
page1Layout := paperwork.ShipmentSummaryPage1Layout
page1Template, err := assets.Asset(page1Layout.TemplateImagePath)
ppmGenerator, err := shipmentsummaryworksheet.NewSSWPPMGenerator()
noErr(err)

page1Reader := bytes.NewReader(page1Template)
err = formFiller.AppendPage(page1Reader, page1Layout.FieldsLayout, page1Data)
ssw, info, err := ppmGenerator.FillSSWPDFForm(page1Data, page2Data)
noErr(err)

// page 2
page2Layout := paperwork.ShipmentSummaryPage2Layout
page2Template, err := assets.Asset(page2Layout.TemplateImagePath)
noErr(err)

page2Reader := bytes.NewReader(page2Template)
err = formFiller.AppendPage(page2Reader, page2Layout.FieldsLayout, page2Data)
noErr(err)

// page 3
page3Layout := paperwork.ShipmentSummaryPage3Layout
page3Template, err := assets.Asset(page3Layout.TemplateImagePath)
noErr(err)

page3Reader := bytes.NewReader(page3Template)
err = formFiller.AppendPage(page3Reader, page3Layout.FieldsLayout, page3Data)
noErr(err)

filename := fmt.Sprintf("shipment-summary-worksheet-%s.pdf", time.Now().Format(time.RFC3339))

output, err := os.Create(filename)
noErr(err)

defer func() {
if closeErr := output.Close(); closeErr != nil {
logger.Error("Could not close output file", zap.Error(closeErr))
}
}()

err = formFiller.Output(output)
noErr(err)

fmt.Println(filename)
fmt.Println(ssw.Name()) // Should always return
fmt.Println(info.PageCount) // Page count should always be 2
// This is a testing command, above lines log information on whether PDF was generated successfully.
}
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
6 changes: 3 additions & 3 deletions pkg/gen/internalapi/configure_mymove.go
Original file line number Diff line number Diff line change
Expand Up @@ -322,9 +322,9 @@ func configureAPI(api *internaloperations.MymoveAPI) http.Handler {
return middleware.NotImplemented("operation service_members.ShowServiceMemberOrders has not yet been implemented")
})
}
if api.MovesShowShipmentSummaryWorksheetHandler == nil {
api.MovesShowShipmentSummaryWorksheetHandler = moves.ShowShipmentSummaryWorksheetHandlerFunc(func(params moves.ShowShipmentSummaryWorksheetParams) middleware.Responder {
return middleware.NotImplemented("operation moves.ShowShipmentSummaryWorksheet has not yet been implemented")
if api.PpmShowShipmentSummaryWorksheetHandler == nil {
api.PpmShowShipmentSummaryWorksheetHandler = ppm.ShowShipmentSummaryWorksheetHandlerFunc(func(params ppm.ShowShipmentSummaryWorksheetParams) middleware.Responder {
return middleware.NotImplemented("operation ppm.ShowShipmentSummaryWorksheet has not yet been implemented")
})
}
if api.MovesSubmitAmendedOrdersHandler == nil {
Expand Down
241 changes: 125 additions & 116 deletions pkg/gen/internalapi/embedded_spec.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading