B 18061 AOA Packet INT

[antgmann]

B-18061

Summary

Is there anything you would like reviewers to give additional scrutiny?

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

1. Run Server, Server Tests
2. Login as a Client User
3. Check Swagger for the ppm -> ppm-shipments/{ppmshipmentid}/aoa-packet api endpoint
4. Find a suitable PPMShipmentId to test with from database (must have ppmshipment capable of producing SSW and uploaded orders), or while logged in as user from the Network tab in dev tools ->MTO Shipments->PPMShipment->id
5. Insert the PPMShipmentId into the "Try it out" section, or just put ID into the template above
6. Test the API, then grab the example URL
7. Paste the example URL into your browser
8. Ensure PDF with SSW and Orders Document appears
9. Repeat steps 2-8 as an office user, with the office API endpoint under the same category and name

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots

[antgmann]

There are some errors causing failure right now due to B-18428 not yet being merged into integration. It has required changes for conflicts between the SSW and the rank refactor

Resolved

[MInthavongsay]

We may have to refactor the PrimeDownloadService to another name to make it more generic in the future. Prime implies Prime usage. Looks good overall.

[MInthavongsay]

Don't know if this is really needed. Middleware would prevent any invocation of this handler without proper authentication.

[antgmann]

I could remove it if that would be better - I just saw it being included in other handlers, and included it as part of figuring out how to prevent access issues

[deandreJones]

is this V9 needed for integrationBranch, or was it added as a part of the exp deployment

[antgmann]

I believe that this change was required for int, as the threshold went down between when I pulled this from main and when I first attempted to PR. However, I haven't tested it since the rebase, so let me take a look and see if it's still necessary.

[antgmann]

After checking my local counts and the baseline on the most recent int pr, errors have been resolved in this branch and the results are below the current integration baseline. I'll revert it to v8

[antgmann]

Spectral lint has been reverted to v8 and the test passes. Thank you for catching this!