Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 18061 AOA Packet INT #12050

Merged
merged 45 commits into from
Feb 26, 2024
Merged

B 18061 AOA Packet INT #12050

Show file tree
Hide file tree
Changes from 41 commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
a493d57
Merge branch 'B-18428-SSW-Form-PDF-Work' into B-18061-AOA-Packet-Comb…
antgmann Jan 31, 2024
1ec8b71
Recreate mocks for SSWPPMGenerator
antgmann Jan 31, 2024
0e3b4e1
Merge B-18027 to use PDF Merge capability
antgmann Feb 1, 2024
70698bc
test api made, found issues with existing SSW api. Going to fix and c…
antgmann Feb 2, 2024
3e6d9db
Merge updated SSW API endpoint
antgmann Feb 2, 2024
2521bea
Working API for AOA Packet
antgmann Feb 2, 2024
8696f6e
All APIs completed, service call working, SSW working, adding Orders …
antgmann Feb 5, 2024
55272f0
Messy solution for combination is working due to generator messiness
antgmann Feb 5, 2024
af41b24
Cleanup complete, next for testing
antgmann Feb 7, 2024
4749aee
Generator test written
antgmann Feb 7, 2024
77cff9c
Internal API Tests made
antgmann Feb 7, 2024
bbdc50d
Potential michael fix before finishing tests
antgmann Feb 7, 2024
1967ad0
Potential fix misleading
antgmann Feb 7, 2024
c84ac47
ghc api tests completed
antgmann Feb 7, 2024
cfe6b8f
Quick fix to ensure ordersFile is correctly generated before AOA crea…
antgmann Feb 7, 2024
3dc627a
Revised order merging function to resolve bookmark error
antgmann Feb 8, 2024
837756f
Tests working
antgmann Feb 9, 2024
1bf8979
small test change and cleanup
antgmann Feb 9, 2024
f3cc7d2
remove file declaration from api dependency
antgmann Feb 9, 2024
d6ad20a
YAML updates for spectral warnings
antgmann Feb 9, 2024
2e2ad0d
increase spectral lint version
antgmann Feb 9, 2024
2584d78
removed / to correct filepath
antgmann Feb 9, 2024
12003fb
More granular datetime for filename uniqueness
antgmann Feb 12, 2024
0e6ffda
add parameter for code reusability
antgmann Feb 12, 2024
df89924
fix api test
antgmann Feb 12, 2024
c6ca5a5
Remove erroneous comment
antgmann Feb 12, 2024
bc843ba
resolve all conflicts with api, updated off of main
antgmann Feb 13, 2024
7b085ba
main merge
antgmann Feb 14, 2024
f0599cf
Remove unused SSW API to reduce vulnerabilities
antgmann Feb 21, 2024
ed43a39
Finalize generated code for SSW endpoint removal
antgmann Feb 21, 2024
e4a530e
Update with new SSW method to reduce downstream risk
antgmann Feb 21, 2024
a5e0d98
Added security feature to prevent uuid hack
antgmann Feb 22, 2024
58d47b5
Caching for SSW template
antgmann Feb 22, 2024
a1b6501
Merge main before integration pr
antgmann Feb 23, 2024
02c0c66
Merge branch 'B-18061-AOA-Packet-Combination' into B-18061-AOA-INT
antgmann Feb 23, 2024
5fb5c94
merge in dependencies for fixing rankgrade conflict
antgmann Feb 23, 2024
cb22a2d
Merge branch 'B-18061-AOA-Packet-Combination' into B-18061-AOA-INT
antgmann Feb 23, 2024
309b304
merge in latest integration testing
antgmann Feb 23, 2024
2876b0a
Merge branch 'integrationTesting' into B-18061-AOA-INT
antgmann Feb 23, 2024
fe905f2
Merge branch 'integrationTesting' into B-18061-AOA-INT
antgmann Feb 23, 2024
0db25f0
Merge branch 'integrationTesting' into B-18061-AOA-INT
antgmann Feb 26, 2024
166a667
Spectral lint version
antgmann Feb 26, 2024
50eb81f
Merge branch 'B-18061-AOA-Packet-Combination' into B-18061-AOA-INT
antgmann Feb 26, 2024
a2cda84
Merge branch 'integrationTesting' into B-18061-AOA-INT
antgmann Feb 26, 2024
ff54219
Merge branch 'integrationTesting' into B-18061-AOA-INT
antgmann Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1240,7 +1240,7 @@ jobs:
#
# The trailing hyphen in restore_cache seems important
# according to the page linked above
- v8-spectral-lint-
- v9-spectral-lint-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this V9 needed for integrationBranch, or was it added as a part of the exp deployment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that this change was required for int, as the threshold went down between when I pulled this from main and when I first attempted to PR. However, I haven't tested it since the rebase, so let me take a look and see if it's still necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After checking my local counts and the baseline on the most recent int pr, errors have been resolved in this branch and the results are below the current integration baseline. I'll revert it to v8

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spectral lint has been reverted to v8 and the test passes. Thank you for catching this!

- run:
name: Save Baseline Spectral Lint
command: |
Expand Down Expand Up @@ -1299,7 +1299,7 @@ jobs:
# Use the BuildNum to update the cache key so that the
# coverage cache is always updated
- save_cache:
key: v8-spectral-lint-{{ .BuildNum }}
key: v9-spectral-lint-{{ .BuildNum }}
paths:
- ~/transcom/mymove/spectral
- store_artifacts:
Expand Down
5 changes: 5 additions & 0 deletions pkg/gen/ghcapi/configure_mymove.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,11 @@ func configureAPI(api *ghcoperations.MymoveAPI) http.Handler {
return middleware.NotImplemented("operation move.SetFinancialReviewFlag has not yet been implemented")
})
}
if api.PpmShowAOAPacketHandler == nil {
api.PpmShowAOAPacketHandler = ppm.ShowAOAPacketHandlerFunc(func(params ppm.ShowAOAPacketParams) middleware.Responder {
return middleware.NotImplemented("operation ppm.ShowAOAPacket has not yet been implemented")
})
}
if api.EvaluationReportsSubmitEvaluationReportHandler == nil {
api.EvaluationReportsSubmitEvaluationReportHandler = evaluation_reports.SubmitEvaluationReportHandlerFunc(func(params evaluation_reports.SubmitEvaluationReportParams) middleware.Responder {
return middleware.NotImplemented("operation evaluation_reports.SubmitEvaluationReport has not yet been implemented")
Expand Down
119 changes: 119 additions & 0 deletions pkg/gen/ghcapi/embedded_spec.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions pkg/gen/ghcapi/ghcoperations/mymove_api.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

62 changes: 62 additions & 0 deletions pkg/gen/ghcapi/ghcoperations/ppm/show_a_o_a_packet.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

71 changes: 71 additions & 0 deletions pkg/gen/ghcapi/ghcoperations/ppm/show_a_o_a_packet_parameters.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading