Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 18896 redefine order audit table ignored columns int 2 #12052

Conversation

traskowskycaci
Copy link
Contributor

Previous int PR

Agility ticket

Summary

Previously, the grade column was in the list of ignored columns for the audit table entries for the orders table. This migration redefines the orders audit table without the grade in that list of ignored columns.

How to test

  1. As a services counselor, go to Move Details and edit the pay grade.
  2. Go to the move history tab.
  3. Verify that you see an event called "Updated orders" and in the details of that event, the updated pay grade.

  1. As a TOO, go to Move Details and edit the pay grade.
  2. Go to the move history tab.
  3. Verify that you see an event called "Updated orders" and in the details of that event, the updated pay grade.

  1. As a TIO, go to Move Details and edit the pay grade.
  2. Go to the move history tab.
  3. Verify that you see an event called "Updated orders" and in the details of that event, the updated pay grade.

Before, no mention of grade being modified in the move history:
image

After:
image

@traskowskycaci traskowskycaci changed the base branch from main to integrationTesting February 23, 2024 15:19
@traskowskycaci traskowskycaci marked this pull request as ready for review February 23, 2024 15:24
@traskowskycaci traskowskycaci requested a review from a team as a code owner February 23, 2024 15:24
@traskowskycaci traskowskycaci self-assigned this Feb 23, 2024
@traskowskycaci traskowskycaci added Mountain Movers Movin' Mountains 1 Sprint at a time INTEGRATION Slated for Integration Testing labels Feb 23, 2024
Copy link
Contributor

@cameroncaci cameroncaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully, meets ac, code looks good and commented well

@traskowskycaci traskowskycaci merged commit 3e7b06d into integrationTesting Feb 26, 2024
30 checks passed
@traskowskycaci traskowskycaci deleted the B-18896-Redefine-order-audit-table-ignored-columns-INT-2 branch February 26, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Mountain Movers Movin' Mountains 1 Sprint at a time
Development

Successfully merging this pull request may close these issues.

3 participants