Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 18840 int #12055

Merged
merged 5 commits into from
Feb 23, 2024
Merged

B 18840 int #12055

merged 5 commits into from
Feb 23, 2024

Conversation

antgmann
Copy link
Contributor

@antgmann antgmann commented Feb 23, 2024

B-18840

Summary

Adds additional columns to the mto_shipments table for pro gear as requested in B-18840 as an upstream enabler to later work.

Is there anything you would like reviewers to give additional scrutiny?
Please ensure database migrations are functional.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Access the database as a developer using a Postgres client tool
  2. View the mto_shipments table
  3. Ensure the two columns actual_pro_gear_weight(INTEGER, NULLABLE) and actual_spouse_pro_gear_weight(INTEGER, NULLABLE) exist. Note: As an enabler, more functional testing will come with downstream tasks that leverage these columns.

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

@antgmann antgmann added Scrummy Bears Scrum Team H INTEGRATION Slated for Integration Testing labels Feb 23, 2024
@antgmann antgmann self-assigned this Feb 23, 2024
@antgmann antgmann requested a review from a team as a code owner February 23, 2024 16:52
Copy link
Contributor

@ajlusk ajlusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New columns were successfully added and tests are passing locally.

@r-mettler r-mettler merged commit 1267f75 into integrationTesting Feb 23, 2024
30 checks passed
@r-mettler r-mettler deleted the B-18840-INT branch February 23, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Scrummy Bears Scrum Team H
Development

Successfully merging this pull request may close these issues.

4 participants