-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B-17910 history audit log - services counselor creates or modifies a shipment #12067
B-17910 history audit log - services counselor creates or modifies a shipment #12067
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
src/constants/MoveHistory/EventTemplates/UpdateCloseoutOffice/updateCloseoutOffice.jsx
Outdated
Show resolved
Hide resolved
src/constants/MoveHistory/EventTemplates/UpdateCloseoutOffice/updateCloseoutOffice.jsx
Outdated
Show resolved
Hide resolved
…modifies-a-shipment-2
…-creates-or-modifies-a-shipment-2
cc535fe
to
732b780
Compare
|
…map in labeleddetails.jsx ln 47 as is for future feature requests
…hub.com:transcom/mymove into B-17910-hal-sc-creates-or-modifies-a-shipment-3-int merging story main branch into story int branch
…-hal-sc-creates-or-modifies-a-shipment-3-int. accepted incoming changes from origin/integrationTesting
…es-a-shipment-2' into B-17910-hal-sc-creates-or-modifies-a-shipment-3-int pulling LabeledDetails.jsx from main story branch
… github.com:transcom/mymove into B-17910-hal-sc-creates-or-modifies-a-shipment-3-int merging main story branch into int story branch
…fies-a-shipment-3-int
…fies-a-shipment-3-int
…hub.com:transcom/mymove into B-17910-hal-sc-creates-or-modifies-a-shipment-2 merging
…hub.com:transcom/mymove into B-17910-hal-sc-creates-or-modifies-a-shipment-3-int merging
…hub.com:transcom/mymove into B-17910-hal-sc-creates-or-modifies-a-shipment-3-int marging changed from main story branch.
… github.com:transcom/mymove into B-17910-hal-sc-creates-or-modifies-a-shipment-3-int merging
…B-17910-hal-sc-creates-or-modifies-a-shipment-3-int merging integrationTesting
…fies-a-shipment-3-int
Agility B-17910
Summary
I have verified the items in the H&AL are correctly shown, and have added the downstream action of the closeout office added to the H&AL, as that is part of the flow for editing/creating a move for the SM.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
(Playwright test for the SM creating a move and the SC getting to the H&AL page not included)
These are to be checked by a reviewer.
Setup to Run the Code
How to test
To make it easier, you can run my automation steps for this:
https://gist.github.com/landan-parker-0/fb8d17ab88b79dabd56d83eb3591bec6
Just dump that into a file named scEditsServiceMemberPPM or something within the test folder: office, where the other playwright flows are.
It will show up as a test
You can run it with command line.
yarn playwright test -g 'services counselor edits ppm'
Frontend
officeApp
class or custommin-width
styling is used to hide any states the would not be visible to the user.Backend
Database
The history fetcher sql file has changed
https://github.com/transcom/mymove/blob/2d9d1bbeb70cdb73a8283892c5265953b539e329/pkg/assets/sql_scripts/move_history_fetcher.sql
Any new migrations/schema changes:
Screenshots