Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B-18060-INTEGRATION- Wire up AOA Packet download link - Customer/Office #12075

Merged
merged 43 commits into from
Feb 28, 2024

Conversation

MInthavongsay
Copy link
Contributor

B-18060

E-05253

Summary

For INTEGRATION

This PR is the culmination of E-05253 -- implementing the click event for the AOA download link introduced by B-18058 and B-18059 and invoking REST API developed in B-18061.

Note, this PR implements both the customer and office AOA download links.

Customer:
Screenshot 2024-02-26 at 9 42 42 PM

Office:
Screenshot 2024-02-26 at 9 42 54 PM

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Follow steps for INT PR for B-18058 - Customer
  2. Follow steps for INT PR for B-18059 - Office

Verify click event downloads file with unique file name. Behavior is similar to the other downloads.

Note: Modal error message will display if there is a runtime error.

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

r-mettler and others added 30 commits January 16, 2024 22:02
…into B-18060-UI-Download-AOA-Packet-Customer
@MInthavongsay MInthavongsay added Scrummy Bears Scrum Team H INTEGRATION Slated for Integration Testing labels Feb 27, 2024
@MInthavongsay MInthavongsay self-assigned this Feb 27, 2024
@MInthavongsay MInthavongsay requested a review from a team as a code owner February 27, 2024 03:17
@robot-mymove
Copy link

Warnings
⚠️

New files have been created under one of the legacy directories
(src/shared or src/scenes). Please relocate them according to the file structure described here.

View the frontend file org ADR for more information

Generated by 🚫 dangerJS against 33dac88

Copy link
Contributor

@landan-parker-0 landan-parker-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems well put together and the tests pass.

👍

Copy link
Contributor

@ajlusk ajlusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended. Tests Pass. UI looks good.

The download link in the customer app didn't work when first tested, however, after restarting the app I was unable to recreate the issue.

@MInthavongsay
Copy link
Contributor Author

AOA download epic.

@MInthavongsay MInthavongsay merged commit 769f224 into integrationTesting Feb 28, 2024
30 checks passed
@MInthavongsay MInthavongsay deleted the B-18060-INT branch February 28, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Scrummy Bears Scrum Team H
Development

Successfully merging this pull request may close these issues.

6 participants