Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B-18896 redefine order audit table ignored columns #12080

Merged

Conversation

traskowskycaci
Copy link
Contributor

Int PR

Agility ticket

Summary

Previously, the grade column was in the list of ignored columns for the audit table entries for the orders table. This migration redefines the orders audit table without the grade in that list of ignored columns.

How to test

  1. As a services counselor, go to Move Details and edit the pay grade.
  2. Go to the move history tab.
  3. Verify that you see an event called "Updated orders" and in the details of that event, the updated pay grade.

  1. As a TOO, go to Move Details and edit the pay grade.
  2. Go to the move history tab.
  3. Verify that you see an event called "Updated orders" and in the details of that event, the updated pay grade.

  1. As a TIO, go to Move Details and edit the pay grade.
  2. Go to the move history tab.
  3. Verify that you see an event called "Updated orders" and in the details of that event, the updated pay grade.

Before, no mention of grade being modified in the move history:
image

After:
image

@traskowskycaci traskowskycaci added the Mountain Movers Movin' Mountains 1 Sprint at a time label Feb 27, 2024
@traskowskycaci traskowskycaci self-assigned this Feb 27, 2024
@traskowskycaci traskowskycaci marked this pull request as ready for review February 27, 2024 17:56
@traskowskycaci traskowskycaci requested a review from a team as a code owner February 27, 2024 17:56
@traskowskycaci traskowskycaci changed the title redefine orders audit history without the grade in ignored column list N-18896 redefine order audit table ignored columns Feb 27, 2024
@traskowskycaci traskowskycaci changed the title N-18896 redefine order audit table ignored columns B-18896 redefine order audit table ignored columns Feb 27, 2024
@cameroncaci
Copy link
Contributor

tiny conflict @traskowskycaci

@traskowskycaci
Copy link
Contributor Author

tiny conflict @traskowskycaci

Fixed!

@deandreJones deandreJones merged commit b0ac37e into main Feb 29, 2024
38 checks passed
@deandreJones deandreJones deleted the B-18896-Redefine-order-audit-table-ignored-columns-MAIN branch February 29, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mountain Movers Movin' Mountains 1 Sprint at a time
Development

Successfully merging this pull request may close these issues.

4 participants