Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTEGRATION - BP-18060 - Wire up AOA packet link customer/office (PART 2 - FIX CUSTOMER ISSUE) #12182

Merged
merged 36 commits into from
Mar 12, 2024

Conversation

MInthavongsay
Copy link
Contributor

B-18060

E-05253

Summary

For INTEGRATION

NOTE: This is a second PR for 18060 for INT. First PR had an issue with the link not working on the customer side. This PR is address the issue by changing the implementation. Created a new shared component as button link. Hopefully this corrects the problem.

This PR is the culmination of E-05253 -- implementing the click event for the AOA download link introduced by B-18058 and B-18059 and invoking REST API developed in B-18061.

Note, this PR implements both the customer and office AOA download links.

Customer:
Screenshot 2024-02-26 at 9 42 42 PM

Office:
Screenshot 2024-02-26 at 9 42 54 PM

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Follow steps for INT PR for B-18058 - Customer
  2. Follow steps for INT PR for B-18059 - Office

Verify click event downloads file with unique file name. Behavior is similar to the other downloads.

Note: Modal error message will display if there is a runtime error.

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

@MInthavongsay MInthavongsay added Scrummy Bears Scrum Team H INTEGRATION Slated for Integration Testing labels Mar 6, 2024
@MInthavongsay MInthavongsay self-assigned this Mar 6, 2024
@MInthavongsay MInthavongsay requested a review from a team as a code owner March 6, 2024 22:06
@robot-mymove
Copy link

robot-mymove commented Mar 6, 2024

Warnings
⚠️

New files have been created under one of the legacy directories
(src/shared or src/scenes). Please relocate them according to the file structure described here.

View the frontend file org ADR for more information

Generated by 🚫 dangerJS against 57ca8cb

@r-mettler
Copy link
Contributor

Was able to download with no issues for Office user
image

@r-mettler
Copy link
Contributor

r-mettler commented Mar 6, 2024

Office user download worked but Customer does not. I just get redirected back to the Customer page and no pdf is downloaded. Looking in the inspector it looks like it doesn't load the new component. It is still a span with a link and not a button like the office apps shows for its download link.
image

Copy link
Contributor

@ajlusk ajlusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AOA Paperwork downloads successfully for both customer and office when multi-move is both enabled and disabled. Testing looks sufficient and tests pass locally.

Copy link
Contributor

@r-mettler r-mettler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to download the AOA packet for Office and Customer.

@r-mettler r-mettler merged commit 2e0ff7b into integrationTesting Mar 12, 2024
30 checks passed
@r-mettler r-mettler deleted the BP-18060-INTEGRATION branch March 12, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Scrummy Bears Scrum Team H
Development

Successfully merging this pull request may close these issues.

8 participants