B-19178 Yellow flag on MTO page persists even after review

[landan-parker-0]

Agility ticket

Summary

Is there anything you would like reviewers to give additional scrutiny?

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

create a move => submit as SC => approve as TOO => login as prime, locate the move, create a shipment => login as

1. Create a move as a services counselor and submit.
2. Approve the move as a TOO
3. Login as a prime user and create a shipment under that move with weight values.
4. Login as TOO and approve the new shipment then navigate to the move task order tab.

• If the weight is over 5,000, if will show a warning alert.

5. The move task order tab should reflect the weights provided when creating the shipment.
6. Set the max billable weight to be equal to or less than the amount of weight for the shipment.

• You should see a warning alert 'This move is at risk for excess weight.
  Review billable weight' with '
  RISK OF EXCESS' in the Estimated weight display value card.

7. Edit the max billable weight by clicking either 'Review billable weight, or the edit symbol on the max billable weight display value card: Set to more than 10% above the estimated weight value.

• The warning should disappear, and the 'risk of excess' text under the estimated weight display value should also disappear.
  If the max billable weight is adjusted to be lower than the estimated weight, it should re-render to show the risk of excess text.

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.

• The requirements listed in Querying the Database Safely have been satisfied.

• Follows our guidelines for Zero-Downtime Deploys.

• Have been communicated to #g-database.

• Secure migrations have been tested following the instructions in our docs.

Screenshots

[paulstonebraker]

I think something is wrong with the math, threshold should be 23,100 but still getting error with this weight (if its helpful at all this is the highest weight where I was still getting an error)

[mergify]

⚠️ The sha of the head commit of this PR conflicts with #12044. Mergify cannot evaluate rules on this PR. ⚠️