-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B-21322 TPPS ECS Scheduled Task - MAIN #14233
Conversation
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
POA'd, git history clean and matches int commits - kudos to being able to maintain that history over so many branches. What was the plan for this one getting tested overnight?
I shall coordinate with Mr. @deandreJones 👀 |
And also the Bright Stars folks, I think they've got a few things to check yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving my approval here, but note to other codeowners, don't merge this one until main is locked and ready for tpps testing in prod (params all set, etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parameters added to stg:
/app-stg/process_tpps_custom_date_file
: Parameter than can be modified if we want to process a custom dated TPPS payment file as opposed to the scheduled daily run where we process the previous day's payment file
Parameters not yet added to stg:
2. /app-stg/tpps_s3_bucket
3. /app-stg/tpps_s3_folder
Can't see for sure but would assume these are also not in prod yet - will update when I know the needed stg and prd env vars have been added
All parameters needed have been added to stg: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All parameters needed have been added to prd
- process_tpps_custom_date_file
- tpps_s3_bucket
- tpps_s3_folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged into main, removing do not merge
label
POA Received to merge into staging and production environment, see Agility ticket comments
Agility ticket
INT PRs:
- There will be some int specific commits in that PR, due to deploying that specific int branch to exp for testing. I tried to remember to throw "int specific commit" in front of those but could've missed some.
https://dp3.atlassian.net/wiki/spaces/MT/pages/1469284485/How+to+create+an+ECS+Scheduled+Task
Agility ticket
Summary
The responsibility of this scheduled task is to grab a TPPS payment file from an S3 bucket, check its ClamAV status to ensure it's CLEAN, and if CLEAN, process the file line by line and store it in our database. Each line in the payment file has an invoice number that will match up to a payment request number.
If no matching payment request number is found, or some error with one line is found, we will continue to process the rest of the entries in the file so that one bad row doesn't keep the rest of the good data in that file from being processed.
The TPPS lambda, which is the service responsible for putting the payment files into the S3 bucket for this new task service to process, should run at 1 a.m. central time. Then at 2 a.m. central time, this task will run once, processing the payment file for the previous day's date.
AWS Config
S3 permissions needed in each environment for this task:
Parameters added for this work to the AWS parameter store:
stg
andprd
environments. The below links are for theexp
env/app-exp/process_tpps_custom_date_file
: Parameter than can be modified if we want to process a custom dated TPPS payment file as opposed to the scheduled daily run where we process the previous day's payment file/app-exp/tpps_s3_bucket
: S3 bucket path for the TPPS payment files/app-exp/tpps_s3_folder
: S3 subfolder inside bucket path for the TPPS payment filesNext steps after testing in exp
Higher environment to-dos after this works in experimental:
.gitlab-ci.yml
underdeploy_tasks_stg
anddeploy_tasks_prd
(was already added todeploy_tasks_dp3
forexp
work):config.yml
underdeploy_tasks_steps
(was already added todeploy_dp3_tasks_steps
forexp
work):Dockerfile.tasks
( was already added toDockerfile.tasks_dp3
):Bright Stars work that enables the work here:
In the terraform-aws-app-environment repo:
In the transcom-infrasec-gov-nonato repo: