-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INT-B-22196 ppm sit cost defect #14576
INT-B-22196 ppm sit cost defect #14576
Conversation
…ent-type MAIN - B-21905 - Rename NTS shipment type
…dSit from the calculation. Disbursement now uses the finalIncentive value before this subtraction. Member disbursement still adds memberpaidsit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing: success
code:lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Agility ticket
Summary
This branch fixes a defect where the payment request packet was including the GTCC paid and Member paid SIT costs in the "Remaining PPM Incentive (pre-tax)" field on page 2. Now, this field will not include these totals, and instead they are only added onto the "Disbursement" fields at the bottom of the same section.
Member paid SIT costs are added to the "Member" disbursement (up to the SIT Reimburseable amount), and the GTCC-paid expense is in it's own "GTCC" section.
How to test
Screenshots