Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT-B-22196 ppm sit cost defect #14576

Merged
merged 11 commits into from
Jan 15, 2025

Conversation

brooklyn-welsh
Copy link
Contributor

@brooklyn-welsh brooklyn-welsh commented Jan 13, 2025

Agility ticket

Summary

This branch fixes a defect where the payment request packet was including the GTCC paid and Member paid SIT costs in the "Remaining PPM Incentive (pre-tax)" field on page 2. Now, this field will not include these totals, and instead they are only added onto the "Disbursement" fields at the bottom of the same section.

Member paid SIT costs are added to the "Member" disbursement (up to the SIT Reimburseable amount), and the GTCC-paid expense is in it's own "GTCC" section.

How to test

  1. Create a PPM shipment as a customer, use the customer and a SC account to take the shipment through the process up to closeout
  2. As the customer, when uploading expense receipts, be sure to include two storage expense receipts, ensure that on one you answer yes to "paid with GTCC", and "no" to the other. Note both amounts that you write in the "amount" field.
  3. Sign as customer, then approve as SC. Back at customer profile, download your payment packet.
  4. On page 2, you should notice that the "Remaining PPM Incentive (pre-tax)" amount and the "Member" disbursement amount are now different. You should also see your exact GTCC paid amount in the "GTCC" disbursement field.
  5. NOTE: the member paid sit cost will probably be different from what you put in if you write in a large amount, since it is limited by the SIT Reimburseable amount calculation, which is influenced by time in storage and weight.

Screenshots

Screenshot 2025-01-14 at 4 08 59 PM
Screenshot 2025-01-14 at 4 22 47 PM

@brooklyn-welsh brooklyn-welsh changed the base branch from main to integrationTesting January 13, 2025 21:57
@brooklyn-welsh brooklyn-welsh changed the title Int b 22196 ppm sit cost defect INT-B-22196 ppm sit cost defect Jan 14, 2025
@brooklyn-welsh brooklyn-welsh added ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing labels Jan 14, 2025
@brooklyn-welsh brooklyn-welsh marked this pull request as ready for review January 14, 2025 21:34
@brooklyn-welsh brooklyn-welsh requested a review from a team as a code owner January 14, 2025 21:34
Copy link
Contributor

@KonstanceH KonstanceH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@JamesHawks224 JamesHawks224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing: success
code:lgtm

Copy link
Contributor

@r-mettler r-mettler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@brooklyn-welsh brooklyn-welsh merged commit e27f09a into integrationTesting Jan 15, 2025
34 checks passed
@brooklyn-welsh brooklyn-welsh deleted the INT-B-22196-PPM-SIT-Cost-Defect branch January 15, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

7 participants