B 22019 rename hhg nts release main #14592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonstanceH
added
ByteSize M&Ms
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
|
KonstanceH
requested review from
taeJungCaci,
JamesHawks224,
brooklyn-welsh and
WeatherfordAaron
taeJungCaci
reviewed
Jan 15, 2025
There was a problem hiding this comment.
I see a few diff on files due the other teams stories not being in Main yet.
Nothing the files missing here as well:
pkg/services/move/move_fetcher.go
pkg/services/mto_service_item/mto_service_item_creator_test.go
There was a problem hiding this comment.
Noting the changes in this file don't seem to match with INT PR - probably the code is not in Main yet
There was a problem hiding this comment.
Also noting the diff here with INT PR - probably because the code is not in main yet. Checked the file and all nts names have been changed.
taeJungCaci
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-21904
Summary
Integration PR: #14559
This PR renames HHG_INTO_NTS_DOMESTIC to HHG_INTO_NTS
Verification Steps for Reviewers
These are to be checked by a reviewer.
How to test
HHG_OUTOF_NTS*create NTS-release as normal. A good tac to use that exists in the db is
E19Ait works for HHG and NTSDon't forget to set the pickup address before you approve the service items for the move.
Frontend
officeAppclass or custommin-widthstyling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots
Database of created NTS release shipment
Successful creation of NTS release shipment's service items
Prime Get API for shipment
