INT-B-21698 PPM Clouseout Calculation Improvement

[brianmanley-caci]

Agility ticket

Summary

Currently the PPM Closeout Feedback page includes Rejected Pro-Gear Weight tickets and Rejected/Excluded Expenses in the calculated total displayed to the customer. This work is to updated the calculation logic to not include rejected (pro-gear, expense) or excluded(expense) values in the calculated total, so that the customer sees a more accurate amount.

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

1. Login to the the Customer application.
2. Create a new move.
3. Create a PPM shipment.
4. Login to the Office application as a Service Counselor.
5. Located the move you created.
6. Enter the required Orders info and Submit the move.
7. Login to the Customer application.
8. Navigate to the move you created.
9. Click the Upload PPM Documents button.
10. On the Weight Tickets page add the following: 3 Weight moved tickets, 3 Pro-gear tickets, 4 expenses 😩
11. On the Review page, verify the Weight moved, Pro-gear, and Expenses totals include all the weights/amounts added by the customer. (This uses the same js function we update to calculate the total, so we're making sure we didn't break this here.)
12. Submit PPM Documentation.
13. Login to the Office application as a Services Counselor.
14. Navigate to the move.
15. Click the Review Documents button.
16. For the Weight and Pro-gear weights, Accept 1, Edit/Accept 1, and Reject 1. For the Expenses, Accept 1, Edit/Accept 1, Reject 1, and Exclude 1.
17. Click the Confirm Button.
18. Access the Customer application.
19. Navigate to your move.
20. Click on the View Closeout Feedback button.
21. Verify that the Weight Moved total includes the approved and edited weights, and does NOT include the rejected weight.
22. Verify that the Prog-gear total includes the approved and edited prog-gear weights, and does NOT include the rejected weight.
23. Verify that the Expenses total includes the approved and edited amounts and does NOT include the rejected and excluded amounts.

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Screenshots

[danieljordan-caci]

lil' stuff

[danieljordan-caci]

So I created three pro-gear things (see what I have AFTER running through your steps)

But before I did that, I clicked the "Review weights" screen and saw this:

The pro-gear one should say 130 and not 80. Not sure if it's related to your work here, but figured I'd bring it up.

[danieljordan-caci]

Totals add up though! Only calculating accepted totals. Nice.

[brianmanley-caci]

So I created three pro-gear things (see what I have AFTER running through your steps)

But before I did that, I clicked the "Review weights" screen and saw this:

The pro-gear one should say 130 and not 80. Not sure if it's related to your work here, but figured I'd bring it up.

There does appear to be an existing issue with the listMTOShipments end point. I created 3 pro-gear weight tickets with 2 being self (50, 75) and 1 being spouse (15).

When the application calls listMTOShipments it is getting the wrong actualProGearWeight amount back. It seems to be using only the last non spouse row maybe (75 in my case, 80 in your example)?

I assume that this is something that would need to be fixed, but I'm not sure that this story is the right place. What do you think?

[danieljordan-caci]

So I created three pro-gear things (see what I have AFTER running through your steps)
But before I did that, I clicked the "Review weights" screen and saw this:
The pro-gear one should say 130 and not 80. Not sure if it's related to your work here, but figured I'd bring it up.

There does appear to be an existing issue with the listMTOShipments end point. I created 3 pro-gear weight tickets with 2 being self (50, 75) and 1 being spouse (15).

When the application calls listMTOShipments it is getting the wrong actualProGearWeight amount back. It seems to be using only the last non spouse row maybe (75 in my case, 80 in your example)?

I assume that this is something that would need to be fixed, but I'm not sure that this story is the right place. What do you think?

If you didn't mess with any of the code, then we can create an issue to address it. Ain't no thang.

[brianmanley-caci]

If you didn't mess with any of the code, then we can create an issue to address it. Ain't no thang.

Issue created in agility Pro-gear weight issue

[antgmann]

🦛 ✅