Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT B-21708 I-13771 #14646

Merged
merged 5 commits into from
Jan 22, 2025
Merged

INT B-21708 I-13771 #14646

merged 5 commits into from
Jan 22, 2025

Conversation

danieljordan-caci
Copy link
Contributor

Agility ticket

Issue ticket

Summary

Calculations were a penny off.

In loadtest during POA, showing 1,405.16:
Screenshot 2025-01-22 at 1 42 43 PM
94.61 * 1.11000 = 105.0171 (round to 105.02)
105.02 * 13.38 = 1,405.1676 (1,405.17)

New & hot:
Screenshot 2025-01-22 at 2 17 01 PM

  • only thing I changed was changing the calculations in cents to calculations in dollars - like the UI does. That fixed the rounding issue.

How to test

  1. Create an iHHG shipment
  2. Approve as SC/TOO
  3. Update port & weights as Prime
  4. Create payment request with ISLH on there
  5. Verify the calculations are correct

@danieljordan-caci danieljordan-caci added Mountain Movers Movin' Mountains 1 Sprint at a time INTEGRATION Slated for Integration Testing labels Jan 22, 2025
@danieljordan-caci danieljordan-caci requested a review from a team January 22, 2025 20:34
@danieljordan-caci danieljordan-caci self-assigned this Jan 22, 2025
@danieljordan-caci danieljordan-caci requested review from a team as code owners January 22, 2025 20:34
cameroncaci
cameroncaci previously approved these changes Jan 22, 2025
Copy link
Contributor

@cameroncaci cameroncaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was there, this math is mathing. Going from an early whole-number round which loses cents in the equation to including cents in the equation by making sure they aren't rounded out

deandreJones
deandreJones previously approved these changes Jan 22, 2025
traskowskycaci
traskowskycaci previously approved these changes Jan 22, 2025
@danieljordan-caci danieljordan-caci merged commit 3cbb7c9 into integrationTesting Jan 22, 2025
31 of 33 checks passed
@danieljordan-caci danieljordan-caci deleted the INT-B-21708-I-13771 branch January 22, 2025 21:25
@danieljordan-caci danieljordan-caci mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Mountain Movers Movin' Mountains 1 Sprint at a time
Development

Successfully merging this pull request may close these issues.

4 participants