Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B 22726 ppm disbursement #14838

Merged
merged 5 commits into from
Feb 25, 2025
Merged

B 22726 ppm disbursement #14838

merged 5 commits into from
Feb 25, 2025

Conversation

loganwc
Copy link
Contributor

@loganwc loganwc commented Feb 19, 2025 •
edited
Loading

Agility ticket

Int PR

Summary

Fixes PPM Disbursement values in ppm packet

How to test

  1. Create a PPM
  2. Approve PPM as SC
  3. Upload PPM documents
    a. Add a SIT expense type (NOT PAID TO GTC)
    b. Add random expense (PAID TO GTC)
  4. Review and approve documents as SC
  5. Download packet as service member.
  6. Make sure member disbursement = total - gtc paid + member paid sit

Screenshots

Screenshot 2025-02-18 at 9 44 21 PM

@loganwc loganwc added G-Unit Scrum Team G MAIN labels Feb 19, 2025
@loganwc loganwc self-assigned this Feb 19, 2025
@loganwc loganwc marked this pull request as ready for review February 24, 2025 18:34
@loganwc loganwc requested a review from a team as a code owner February 24, 2025 18:34
paulstonebraker
paulstonebraker approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@paulstonebraker paulstonebraker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes match

@pambecker pambecker merged commit 4f3e296 into main Feb 25, 2025
11 of 14 checks passed
@pambecker pambecker deleted the B-22726-PPM-Disbursement branch February 25, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulstonebraker paulstonebraker paulstonebraker approved these changes

@pambecker pambecker pambecker approved these changes

@joeydoyecaci joeydoyecaci Awaiting requested review from joeydoyecaci

@JonSpight JonSpight Awaiting requested review from JonSpight

Assignees

@loganwc loganwc

Labels
G-Unit Scrum Team G MAIN
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loganwc @paulstonebraker @pambecker