B-21350-INT Bulk assignment modal equal assignment button

[paulstonebraker]

Agility ticket

Summary

This work adds checkboxes to the bulk assignment modal for the purposes of equal assignment. I am very open to suggestions on this PR if anyone has suggestions on managing the state of selected/checked users, or the math for equal assignment :)

Changes in primeapiv2 are from main
Changes in adminapi and rejected_office_user_service_test.go are from linter

How to test

1. Login as a supervisor
2. Click bulk assignment button
3. Confirm all checkboxes begin selected
4. Check and uncheck boxes, use the column header to select/deselect all, click equal assign, make sure everything is working as intended
5. Save and make sure thats working
6. Try and break while also testing existing functionality to make sure i didn't screw up a merge somewhere or anything please!

[loganwc]

#14867 should go first

[pambecker]

Can we fix this placement, have the button on the outside still when this message displays?

[paulstonebraker]

Can we fix this placement, have the button on the outside still when this message displays?

Good find, will do

[danieljordan-caci]

I'd like to request some changes to the error message that displays by changing it to this:

          {isError && (
            <Alert type="error" headingLevel="h4" slim>
              {errorMessage}
            </Alert>
          )}

I'm cool with it being at the top or the bottom, here's a screenshot for both:

Looks a lot cleaner to me and uses functionality we use throughout the app

[danieljordan-caci]

Also want to make sure that you're clearing that error when the user clicks the cancel button, etc

[paulstonebraker]

When I first come into the Bulk Assign modal, I don't think we should be selecting the checkboxes right away. I think by default they should be unchecked. And then the Equal Assign button disable to start also.

Updated AC to include them being preselected at request of PO

[paulstonebraker]

I'd like to request some changes to the error message that displays by changing it to this:

          {isError && (
            <Alert type="error" headingLevel="h4" slim>
              {errorMessage}
            </Alert>
          )}

I'm cool with it being at the top or the bottom, here's a screenshot for both:

Looks a lot cleaner to me and uses functionality we use throughout the app

Sweet, appreciate the code snippet and looks good

[paulstonebraker]

Also want to make sure that you're clearing that error when the user clicks the cancel button, etc

What do you mean by this? I think if they click cancel, and are viewing the confirmation modal, error should still be there like so

but open to discussion.

[danieljordan-caci]

Also want to make sure that you're clearing that error when the user clicks the cancel button, etc

What do you mean by this? I think if they click cancel, and are viewing the confirmation modal, error should still be there like so

but open to discussion.

I think at that point it seems irrelevant imo - because we've showed it to them and then they took another action so we can assume they've seen it and feels right to clear it

[paulstonebraker]

Also want to make sure that you're clearing that error when the user clicks the cancel button, etc

What do you mean by this? I think if they click cancel, and are viewing the confirmation modal, error should still be there like so

but open to discussion.

I think at that point it seems irrelevant imo - because we've showed it to them and then they took another action so we can assume they've seen it and feels right to clear it

I disagree but I am also mostly indifferent so I'll defer to you!

[pambecker]

Also want to make sure that you're clearing that error when the user clicks the cancel button, etc

What do you mean by this? I think if they click cancel, and are viewing the confirmation modal, error should still be there like so

but open to discussion.

I think at that point it seems irrelevant imo - because we've showed it to them and then they took another action so we can assume they've seen it and feels right to clear it

I do agree, we should clear the message after the user takes an action.

[paulstonebraker]

@danieljordan-caci @pambecker updated error message placement, using for the error, clearing the error, disabling the save if form is unchanged, and no prompting user with the cancel confirmation if the form is unchanged. I think.

[danieljordan-caci]

Might need to look at the storybook for the modal - ghostin' ya

[paulstonebraker]

Might need to look at the storybook for the modal - ghostin' ya

🤬

[paulstonebraker]

@danieljordan-caci Updated, sorry about not checking Happo