Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAIN B-22267 #14846

Merged
merged 12 commits into from
Mar 6, 2025
Merged

MAIN B-22267 #14846

merged 12 commits into from
Mar 6, 2025

Conversation

danieljordan-caci
Copy link
Contributor

@danieljordan-caci danieljordan-caci commented Feb 19, 2025

INT PR
INT PR 2

NOTE:
There was an INT specific commit in the v2 PR that is almost complete, but @TevinAdams's 21378 had a test (TestUpdateRequiredDeliveryDateUpdate) that is not yet in main so it is missing that specific change only

Agility ticket

Summary

When we first did pricing for international shipments, we were told to use DTOD for all mileage calculations, which was noted in the feature. Looks like that was incorrect so this BL is addressing dialing that requirement back and using RandMcNally aka "MilMove Miles" instead of DTOD per our GHC contract.

If we run into errors where there aren't associated rows in zip3_distances, then we need to consider that a data issue and add those ZIP combos to the database with the associated mileage. I've tested with quite a few ZIP combos, so please ensure you do a few moves with some different ZIP combos.

I've also updated a couple times where ZipTransitDistance is called to check for isInternationalShipment and where that wasn't possible I added comments explaining why the value was true or false

How to test

  1. Create some moves, make a couple OCONUS with AK ZIPs
  2. Go through the end to end flow alllll the way until you review the fuel surcharge as TIO
  3. Verify that the mileage shown in the calculations is what is found in zip3_distances

Screenshots

Screenshot 2025-02-19 at 4 28 58 PM
Screenshot 2025-02-19 at 4 29 23 PM

@danieljordan-caci danieljordan-caci added Mountain Movers Movin' Mountains 1 Sprint at a time MAIN labels Feb 19, 2025
@danieljordan-caci danieljordan-caci self-assigned this Feb 19, 2025
@danieljordan-caci danieljordan-caci marked this pull request as ready for review March 5, 2025 22:12
@danieljordan-caci danieljordan-caci requested a review from a team as a code owner March 5, 2025 22:12
Copy link
Contributor

@cameroncaci cameroncaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing missing commits from the int PRs, for example this section
image

@danieljordan-caci
Copy link
Contributor Author

Seeing missing commits from the int PRs, for example this section image

That's from the destination queue BL - not relevant

Copy link
Contributor

@cameroncaci cameroncaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POA'd. Commits are kinda not good, but are technically good. HOWEVER, all commits present in the main branch are in fact present in int, it's just that int has other backlog item commits present per @danieljordan-caci. The V2 PR is a good match, just the V1 that gets a little silly

@danieljordan-caci
Copy link
Contributor Author

POA'd. Commits are kinda not good, but are technically good. HOWEVER, all commits present in the main branch are in fact present in int, it's just that int has other backlog item commits present per @danieljordan-caci. The V2 PR is a good match, just the V1 that gets a little silly

Sorry about the mess lol

Copy link
Contributor

@traskowskycaci traskowskycaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches other than the commit you called out. @TevinAdams making sure you see this PR and know that you may want to merge in main to your 21378 main branch and update your tests impacted here

@cameroncaci cameroncaci merged commit 5566dce into main Mar 6, 2025
11 of 14 checks passed
@cameroncaci cameroncaci deleted the MAIN-B-22267 branch March 6, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MAIN Mountain Movers Movin' Mountains 1 Sprint at a time
Development

Successfully merging this pull request may close these issues.

3 participants