-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAIN B-22267 #14846
MAIN B-22267 #14846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
POA'd. Commits are kinda not good, but are technically good. HOWEVER, all commits present in the main branch are in fact present in int, it's just that int has other backlog item commits present per @danieljordan-caci. The V2 PR is a good match, just the V1 that gets a little silly
Sorry about the mess lol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches other than the commit you called out. @TevinAdams making sure you see this PR and know that you may want to merge in main to your 21378 main branch and update your tests impacted here
INT PR
INT PR 2
NOTE:
There was an INT specific commit in the v2 PR that is almost complete, but @TevinAdams's 21378 had a test (
TestUpdateRequiredDeliveryDateUpdate
) that is not yet inmain
so it is missing that specific change onlyAgility ticket
Summary
When we first did pricing for international shipments, we were told to use DTOD for all mileage calculations, which was noted in the feature. Looks like that was incorrect so this BL is addressing dialing that requirement back and using RandMcNally aka "MilMove Miles" instead of DTOD per our GHC contract.
If we run into errors where there aren't associated rows in
zip3_distances
, then we need to consider that a data issue and add those ZIP combos to the database with the associated mileage. I've tested with quite a few ZIP combos, so please ensure you do a few moves with some different ZIP combos.I've also updated a couple times where
ZipTransitDistance
is called to check forisInternationalShipment
and where that wasn't possible I added comments explaining why the value wastrue
orfalse
How to test
zip3_distances
Screenshots