-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Int b 22039 remove lat lon #14857
Int b 22039 remove lat lon #14857
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger
Smaller No assets were smaller Unchanged
|
3929cd6
to
27f2f5a
Compare
I am having trouble building your INT branch locally. I keep getting Side note would it make sense to add a test for |
We have found that it is very difficult to add test files for the admin app. It's how the library |
Oh ok that is interesting. @ryan-mchugh I will leave it up to you and won't block it for this PR |
yep, need to do a refresh on the db to get it running. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working well for me 🎉
B-22039 - Admin - Offices Data - Remove Lat/Lont
Summary
We're removing Latitude and Longitude from the Admin app UI. Three files noted in the ticket description.
I took the liberty to also remove from admin api since no longer being referenced from app.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
Frontend
officeApp
class or custommin-width
styling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots
Before

w/ Changes
