Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Int b 22039 remove lat lon #14857

Merged
merged 6 commits into from
Feb 26, 2025
Merged

Int b 22039 remove lat lon #14857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cf795c0
B-22039 - remove lat & lon per locations enumerated in description.
ryan-mchugh Feb 20, 2025
6e533cf
Merge branch 'main' of github.com:transcom/mymove into MAIN-B-22039-r…
ryan-mchugh Feb 20, 2025
e44b4ba
Merge branch 'MAIN-B-22039-remove_lat_lon' into INT-B-22039-remove_la…
ryan-mchugh Feb 21, 2025
27f2f5a
Merge branch 'integrationTesting' of github.com:transcom/mymove into …
ryan-mchugh Feb 21, 2025
79a3e64
Merge branch 'integrationTesting' into INT-B-22039-remove_lat_lon
msaki-caci Feb 25, 2025
a37f066
Merge branch 'integrationTesting' of github.com:transcom/mymove into …
ryan-mchugh Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions pkg/gen/adminapi/embedded_spec.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 0 additions & 8 deletions pkg/gen/adminmessages/transportation_office.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/handlers/adminapi/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func NewAdminAPI(handlerConfig handlers.HandlerConfig) *adminops.MymoveAPI {
pagination.NewPagination,
}

adminAPI.RejectedOfficeUsersGetRejectedOfficeUserHandler = GetRejectedOfficeUserHandler{
adminAPI.RejectedOfficeUsersGetRejectedOfficeUserHandler = GetRejectedOfficeUserHandler{
handlerConfig,
rejectedofficeusers.NewRejectedOfficeUserFetcher(queryBuilder),
newRolesFetcher,
Expand Down
2 changes: 0 additions & 2 deletions pkg/handlers/adminapi/offices.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ func payloadForOfficeModel(o models.TransportationOffice) *adminmessages.Transpo
Address: payloadForAddressModel(&o.Address),
Gbloc: o.Gbloc,
PhoneLines: payloadForPhoneLines(o.PhoneLines),
Latitude: o.Latitude,
Longitude: o.Longitude,
}
}

Expand Down
3 changes: 2 additions & 1 deletion pkg/handlers/adminapi/rejected_office_users_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"github.com/go-openapi/strfmt"
"github.com/gofrs/uuid"
"github.com/stretchr/testify/mock"

"github.com/transcom/mymove/pkg/factory"
rejectedofficeuserop "github.com/transcom/mymove/pkg/gen/adminapi/adminoperations/rejected_office_users"
"github.com/transcom/mymove/pkg/handlers"
Expand Down Expand Up @@ -182,4 +183,4 @@ func (suite *HandlerSuite) TestGetRejectedOfficeUserHandler() {
}
suite.Equal(expectedResponse, response)
})
}
}
2 changes: 1 addition & 1 deletion pkg/services/rejected_office_users/rejected_office_user_service_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ func TestUserSuite(t *testing.T) {
}
suite.Run(t, ts)
ts.PopTestSuite.TearDown()
}
}
2 changes: 1 addition & 1 deletion playwright/tests/admin/offices.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ test.describe('Offices Page', () => {
await expect(page.locator('header')).toContainText('Offices');
await expect(page.getByLabel('Search by Office Name')).toBeEditable();

const columnLabels = ['Id', 'Name', 'Latitude', 'Longitude', 'Gbloc'];
const columnLabels = ['Id', 'Name', 'Gbloc'];
await adminPage.expectRoleLabelsByText('columnheader', columnLabels);
});
});
2 changes: 0 additions & 2 deletions src/pages/Admin/Offices/OfficeList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ const OfficeList = () => (
<Datagrid bulkActionButtons={false}>
<TextField source="id" />
<TextField source="name" />
<TextField source="latitude" />
<TextField source="longitude" />
<TextField source="gbloc" />
</Datagrid>
</List>
Expand Down
8 changes: 0 additions & 8 deletions swagger-def/admin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1055,14 +1055,6 @@ definitions:
type: string
pattern: "^[A-Z]{4}$"
example: JENQ
latitude:
type: number
format: float
example: 29.382973
longitude:
type: number
format: float
example: -98.62759
createdAt:
type: string
format: date-time
Expand Down
8 changes: 0 additions & 8 deletions swagger/admin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1062,14 +1062,6 @@ definitions:
type: string
pattern: ^[A-Z]{4}$
example: JENQ
latitude:
type: number
format: float
example: 29.382973
longitude:
type: number
format: float
example: -98.62759
createdAt:
type: string
format: date-time
Expand Down