B 22087 int - Number of shipments in the search queue not decreasing when shipments are deleted

[JonSpight]

Agility ticket

Summary

When there are multiple shipments and 1 is deleted, the number of shipments does not account for the deleted shipment

How to test

1. Create a Move with four shipments (all either approved or submitted status).
2. Sign in as a Service Counselor and search for the move using the move code.
3. Verify the # of shipments is four.
4. repeat steps 2-3 as TOO.
5. repeat steps 2-3 as TIO.
6. Change one of the shipments status to REJECTED.
7. Change one of the shipments status to CANCELED.
8. Delete one shipment
9. Sign in as a Service Counselor and search for the move using the move code.
10. Verify the # of shipments is one.
11. repeat steps 6- 9 but as TOO.
12. repeat steps 6- 9 but as TIO.

[danieljordan-caci]

The way that I read the AC and understand it, is they still want rejected/canceled shipments to be included no? They just don't want to include deleted shipments.

If that's not the case, then I'd recommend updating the AC and getting clarification since rejected/canceled shipments still show on the MTO page.

I'd recommend you check out ExcludeDeletedScope in the backend to help you out and not return deleted shipments when querying the db.

[danieljordan-caci]

After talking with @JonSpight on Slack, seems like we might have some limitations with Pop and so we are unable to use ExcludeDeletedScope() effectively as well as adding an explicit

query := appCtx.DB().Q().Where("mto_shipments.deleted_at IS NULL")

to where we can filter these out at the db successfully

Think the approach is fine, but would suggest moving the filtering closer to the service object and filtering out deleted shipments within the order fetcher & move search functions

[paulstonebraker]

tested and ready to approve, just waiting to hear back from Jon on if MTOShipmentStatusCancellationRequested should be included or excluded in the count

[paulstonebraker]

I had previously tested with the changes from the most recent commit so I am comfortable approving!

[pambecker]

Can you please update the 'How to test' above as well, to match the new findings and not include Cancellation Requested.

[danieljordan-caci]

very nice!