Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B-22227 Prime API address validation #14870

Merged
merged 39 commits into from
Feb 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
8c8662c
check address on dest address update
r-mettler Jan 25, 2025
30622f7
print error message when lookup fails, optional exactMatch bool
r-mettler Jan 27, 2025
25005a1
add getLocations endpoint to prime api
r-mettler Jan 27, 2025
f45238a
add address check to createMTOShipment v3
r-mettler Jan 28, 2025
f22ab45
validate address for create and update shipment v2 v3
r-mettler Jan 28, 2025
a6b9f96
updating for tests
r-mettler Jan 29, 2025
1593a6c
adding tests for create shipment v3
r-mettler Jan 29, 2025
70d1f5e
Merge branch 'main' of github.com:transcom/mymove into B-22227
r-mettler Jan 29, 2025
d6d3e52
adding update shipment tests
r-mettler Jan 29, 2025
2ada175
adding update dest address test
r-mettler Jan 29, 2025
23a9c58
Merge branch 'main' of github.com:transcom/mymove into B-22227
r-mettler Jan 29, 2025
0e29e9f
updated comment for test
r-mettler Jan 29, 2025
df4ee55
fixing update test v3
r-mettler Jan 29, 2025
018071d
remove check for multiple results since shouldn't happen
r-mettler Jan 29, 2025
8e8317c
mock get location to throw error for test coverage
r-mettler Jan 30, 2025
a737967
Merge branch 'main' of github.com:transcom/mymove into B-22227
r-mettler Jan 30, 2025
8908786
adding more tests
r-mettler Jan 31, 2025
a52e193
increase test coverage some more
r-mettler Jan 31, 2025
20315ba
updating tests
r-mettler Jan 31, 2025
22c76ca
more tests, coverage better be happy
r-mettler Jan 31, 2025
7625b39
Merge branch 'main' of github.com:transcom/mymove into B-22227
r-mettler Jan 31, 2025
acd2170
Merge branch 'main' of github.com:transcom/mymove into B-22227
r-mettler Jan 31, 2025
0f456b5
change test description to success
r-mettler Feb 10, 2025
9d868a6
Merge branch 'main' of github.com:transcom/mymove into B-22227
r-mettler Feb 10, 2025
29ada4a
Merge branch 'main' of github.com:transcom/mymove into B-22227
r-mettler Feb 10, 2025
9868e06
Merge remote-tracking branch 'origin/main' into B-22227
ajlusk Feb 11, 2025
e09f6a4
Merge branch 'main' of github.com:transcom/mymove into B-22227
r-mettler Feb 12, 2025
3650eec
Merge branch 'B-22227' of github.com:transcom/mymove into B-22227
r-mettler Feb 12, 2025
cdc27ba
moving new tests to end of file for cleaner diff view
r-mettler Feb 12, 2025
5ce2181
Merge branch 'main' of github.com:transcom/mymove into B-22227
r-mettler Feb 12, 2025
0983369
Merge branch 'main' of github.com:transcom/mymove into B-22227
r-mettler Feb 21, 2025
357ced9
Merge branch 'main' of github.com:transcom/mymove into B-22227
r-mettler Feb 21, 2025
0658b2b
Merge branch 'main' into B-22227
r-mettler Feb 21, 2025
65d5f1d
fixing order of vLocationServices in update, thou hast faile me git m…
r-mettler Feb 21, 2025
29daa81
Merge branch 'B-22227' of github.com:transcom/mymove into B-22227
r-mettler Feb 21, 2025
60a30df
Merge branch 'main' into B-22227
r-mettler Feb 24, 2025
3f4a27f
Merge branch 'main' into B-22227
r-mettler Feb 24, 2025
41bea85
Merge branch 'main' into B-22227
r-mettler Feb 25, 2025
3d4bbce
Merge branch 'main' into B-22227
r-mettler Feb 25, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/gen/primeapi/configure_mymove.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"github.com/go-openapi/runtime/middleware"

"github.com/transcom/mymove/pkg/gen/primeapi/primeoperations"
"github.com/transcom/mymove/pkg/gen/primeapi/primeoperations/addresses"
"github.com/transcom/mymove/pkg/gen/primeapi/primeoperations/move_task_order"
"github.com/transcom/mymove/pkg/gen/primeapi/primeoperations/mto_service_item"
"github.com/transcom/mymove/pkg/gen/primeapi/primeoperations/mto_shipment"
Expand Down Expand Up @@ -100,6 +101,11 @@ func configureAPI(api *primeoperations.MymoveAPI) http.Handler {
return middleware.NotImplemented("operation move_task_order.DownloadMoveOrder has not yet been implemented")
})
}
if api.AddressesGetLocationByZipCityStateHandler == nil {
api.AddressesGetLocationByZipCityStateHandler = addresses.GetLocationByZipCityStateHandlerFunc(func(params addresses.GetLocationByZipCityStateParams) middleware.Responder {
return middleware.NotImplemented("operation addresses.GetLocationByZipCityState has not yet been implemented")
})
}
if api.MoveTaskOrderGetMoveTaskOrderHandler == nil {
api.MoveTaskOrderGetMoveTaskOrderHandler = move_task_order.GetMoveTaskOrderHandlerFunc(func(params move_task_order.GetMoveTaskOrderParams) middleware.Responder {
return middleware.NotImplemented("operation move_task_order.GetMoveTaskOrder has not yet been implemented")
Expand Down
Loading
Loading