B-22307 int deleted documents use db function

[r-mettler]

B-22306

B-22307

22306/22307 INT PR 1

22306 INT PR

22307 INT PR

Summary

This PR contains B-22306 and B-22307. Previously the method used a Pop query that when called with includeDeletedDocs the query would sometimes fail to find an alias to the documents table and throw an error. Other cases the method would cause errors when trying to retrieve documents because it was retrieving files that were soft deleted (had a date in the deleted_at field). These backlogs introduce a new database function to retrieve only documents that have not been soft deleted.

Is there anything you would like reviewers to give additional scrutiny?

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

Upload and delete every document you can and make sure it doesn't throw an error. Also create and delete things like moving expenses, weight tickets, and pro gear documents after you have uploaded documents and when you have not uploaded documents. Do this from the Customer and Office apps.

Make sure you can download an AOA packet and Payment Packet for PPMs as customer and office user.

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots

[ajlusk]

Seems to match INT now 👍