Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAIN B-22653 #14889

Merged
merged 5 commits into from
Feb 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -883,6 +883,7 @@ commands:
export ENVIRONMENT=test
export FEATURE_FLAG_MULTI_MOVE=true
export FEATURE_FLAG_PPM=true
export FEATURE_FLAG_PPM_SPR=false
export FEATURE_FLAG_NTS=true
export FEATURE_FLAG_NTSR=true
export FEATURE_FLAG_BOAT=true
Expand Down
1 change: 1 addition & 0 deletions .envrc
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ export FEATURE_FLAG_QUEUE_MANAGEMENT=true

# Feature flags to disable certain shipment types
export FEATURE_FLAG_PPM=true
export FEATURE_FLAG_PPM_SPR=false
export FEATURE_FLAG_NTS=true
export FEATURE_FLAG_NTSR=true
export FEATURE_FLAG_BOAT=true
Expand Down
1 change: 1 addition & 0 deletions config/env/demo.app-client-tls.env
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ TELEMETRY_USE_XRAY_ID=true
TLS_ENABLED=true
FEATURE_FLAG_MULTI_MOVE=false
FEATURE_FLAG_PPM=true
FEATURE_FLAG_PPM_SPR=false
FEATURE_FLAG_NTS=true
FEATURE_FLAG_NTSR=true
FEATURE_FLAG_BOAT=false
Expand Down
1 change: 1 addition & 0 deletions config/env/demo.app.env
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ SERVE_API_SUPPORT=true
FEATURE_FLAG_MULTI_MOVE=false
FEATURE_FLAG_COUNSELOR_MOVE_CREATE=false
FEATURE_FLAG_PPM=true
FEATURE_FLAG_PPM_SPR=false
FEATURE_FLAG_NTS=true
FEATURE_FLAG_NTSR=true
FEATURE_FLAG_BOAT=false
Expand Down
1 change: 1 addition & 0 deletions config/env/exp.app-client-tls.env
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ TELEMETRY_ENDPOINT=localhost:4317
TELEMETRY_USE_XRAY_ID=false
FEATURE_FLAG_MULTI_MOVE=false
FEATURE_FLAG_PPM=true
FEATURE_FLAG_PPM_SPR=false
FEATURE_FLAG_NTS=true
FEATURE_FLAG_NTSR=true
FEATURE_FLAG_BOAT=false
Expand Down
1 change: 1 addition & 0 deletions config/env/exp.app.env
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ TELEMETRY_USE_XRAY_ID=true
FEATURE_FLAG_MULTI_MOVE=true
FEATURE_FLAG_COUNSELOR_MOVE_CREATE=false
FEATURE_FLAG_PPM=true
FEATURE_FLAG_PPM_SPR=false
FEATURE_FLAG_NTS=true
FEATURE_FLAG_NTSR=true
FEATURE_FLAG_BOAT=false
Expand Down
1 change: 1 addition & 0 deletions config/env/loadtest.app-client-tls.env
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ TELEMETRY_USE_XRAY_ID=true
TLS_ENABLED=true
FEATURE_FLAG_MULTI_MOVE=false
FEATURE_FLAG_PPM=true
FEATURE_FLAG_PPM_SPR=false
FEATURE_FLAG_NTS=true
FEATURE_FLAG_NTSR=true
FEATURE_FLAG_BOAT=false
Expand Down
1 change: 1 addition & 0 deletions config/env/loadtest.app.env
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ SERVE_API_SUPPORT=true
FEATURE_FLAG_MULTI_MOVE=false
FEATURE_FLAG_COUNSELOR_MOVE_CREATE=false
FEATURE_FLAG_PPM=true
FEATURE_FLAG_PPM_SPR=false
FEATURE_FLAG_NTS=true
FEATURE_FLAG_NTSR=true
FEATURE_FLAG_BOAT=false
Expand Down
1 change: 1 addition & 0 deletions config/env/prd.app-client-tls.env
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ TELEMETRY_USE_XRAY_ID=true
TLS_ENABLED=true
FEATURE_FLAG_MULTI_MOVE=false
FEATURE_FLAG_PPM=false
FEATURE_FLAG_PPM_SPR=false
FEATURE_FLAG_NTS=false
FEATURE_FLAG_NTSR=false
FEATURE_FLAG_BOAT=false
Expand Down
1 change: 1 addition & 0 deletions config/env/prd.app.env
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ SERVE_API_SUPPORT=false
FEATURE_FLAG_MULTI_MOVE=false
FEATURE_FLAG_COUNSELOR_MOVE_CREATE=false
FEATURE_FLAG_PPM=false
FEATURE_FLAG_PPM_SPR=false
FEATURE_FLAG_NTS=false
FEATURE_FLAG_NTSR=false
FEATURE_FLAG_BOAT=false
Expand Down
1 change: 1 addition & 0 deletions config/env/stg.app-client-tls.env
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ TELEMETRY_USE_XRAY_ID=true
TLS_ENABLED=true
FEATURE_FLAG_MULTI_MOVE=false
FEATURE_FLAG_PPM=true
FEATURE_FLAG_PPM_SPR=false
FEATURE_FLAG_NTS=true
FEATURE_FLAG_NTSR=true
FEATURE_FLAG_BOAT=false
Expand Down
1 change: 1 addition & 0 deletions config/env/stg.app.env
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ SERVE_API_SUPPORT=true
FEATURE_FLAG_MULTI_MOVE=false
FEATURE_FLAG_COUNSELOR_MOVE_CREATE =false
FEATURE_FLAG_PPM=true
FEATURE_FLAG_PPM_SPR=false
FEATURE_FLAG_NTS=true
FEATURE_FLAG_NTSR=true
FEATURE_FLAG_BOAT=false
Expand Down
16 changes: 16 additions & 0 deletions config/flipt/storage/development.features.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,14 @@ flags:
- segment:
key: mil-app
value: false
- key: enable_hawaii
name: Enable Hawaii feature flag
type: BOOLEAN_FLAG_TYPE
enabled: false
rollouts:
- segment:
key: mil-app
value: false
- key: okta_dodid_input
name: Customer DODID input being pulled from Okta and disabling text input
type: BOOLEAN_FLAG_TYPE
Expand All @@ -89,6 +97,14 @@ flags:
- segment:
key: mil-app
value: true
- key: ppm_spr
name: Enable PPM Small Package Reimbursement flag
type: BOOLEAN_FLAG_TYPE
enabled: false
rollouts:
- segment:
key: mil-app
value: false
- key: nts
name: NTS feature flag
type: BOOLEAN_FLAG_TYPE
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
-- B-22653 Daniel Jordan add ppm_type column to ppm_shipments
ALTER TABLE ppm_shipments
ADD COLUMN IF NOT EXISTS ppm_type ppm_shipment_type NOT NULL DEFAULT 'INCENTIVE_BASED';
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
-- B-22653 Daniel Jordan add ppm_shipment_type
DO $$
BEGIN
IF NOT EXISTS (SELECT 1 FROM pg_type WHERE typname = 'ppm_shipment_type') THEN
CREATE TYPE ppm_shipment_type AS ENUM (
'INCENTIVE_BASED',
'ACTUAL_EXPENSE',
'SMALL_PACKAGE'
);
END IF;
END $$;
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
-- B-22653 Daniel Jordan update moving_expense_type to include SMALL_PACKAGE
ALTER TYPE moving_expense_type ADD VALUE IF NOT EXISTS 'SMALL_PACKAGE';
1 change: 1 addition & 0 deletions migrations/app/ddl_tables_manifest.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# This is the tables migrations manifest.
# If a migration is not recorded here, then it will error.
# Naming convention: tbl_some_table.up.sql running <generate-ddl-migration some_table tables> will create this file.
20250224200700_tbl_ppm_shipments.up.sql
2 changes: 2 additions & 0 deletions migrations/app/ddl_types_manifest.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# This is the types migrations manifest.
# If a migration is not recorded here, then it will error.
# Naming convention: ty_some_type.up.sql running <generate-ddl-migration some_type types> will create this file.
20250224202726_ty_ppm_shipment_type.up.sql
20250224202738_ty_moving_expenses_type.up.sql
1 change: 1 addition & 0 deletions pkg/factory/ppm_shipment_factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ func buildPPMShipmentWithBuildType(db *pop.Connection, customs []Customization,
}

ppmShipment := models.PPMShipment{
PPMType: models.PPMType(models.PPMTypeIncentiveBased),
ShipmentID: shipment.ID,
Shipment: shipment,
Status: models.PPMShipmentStatusDraft,
Expand Down
28 changes: 28 additions & 0 deletions pkg/gen/ghcapi/embedded_spec.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

46 changes: 46 additions & 0 deletions pkg/gen/ghcmessages/p_p_m_shipment.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

92 changes: 92 additions & 0 deletions pkg/gen/ghcmessages/p_p_m_type.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading