Int b 22633

[antgmann]

B-22633

Summary

This PR takes the first steps towards allowing a SC to create a PPM Shipment at any point in the move. Firstly, when they create a PPM, it needs to automatically configure to the "Waiting on Customer" status.

This PR achieves this by, when creating the data for a PPM, if the signed in user contains the SC role, they will automatically certify their approval of the PPM and set the shipment status to "Waiting on Customer". At this point, they will no longer be able to edit the shipment.

Due to the nature of this change, SC's will now have a warning appear whenever creating a PPM Shipment that alerts them to this. Additionally, on the move details page, the "Edit shipment" button for PPM shipments is now appearing based on ppm shipment status rather than move status.

Testing changes include coverage for the edit shipment button changes, the appearance of the warning, the status change when an SC creates a PPM on the backend, and additional testing to add app context roles to certain handlers that hit the service where the role check is occuring.

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

How to test

1. Access the application as a service member.
2. Create a new move, preferably with an HHG Shipment.
3. Submit the move.
4. As a Service Counselor (NOT multirole!), log in and create a new PPM Shipment on this move. Note: Editing PPM Shipments is now based on PPM Status instead of move status.
5. Ensure the shipment is automatically sent to the "Waiting on Customer" status.
6. Ensure the Move History tab contains an ApprovedAt date for the shipment.
7. As your service member, run through the PPM Shipment/closeout process in various stages of the move and ensure it still functions properly.
8. Log in as a TOO (NOT multirole!) and access a move.
9. Create a PPM and note that it is sent to a "Submitted" status.
10. Attempt to break it! Any sort of process out-of-order error should be covered by the unique process of PPM Shipments, but an issue in that ballpark is possible due to the nature of this task.

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Screenshots

[ryan-mchugh]

Can you add PPMs with statuses of DRAFT and NEEDS_ADVANCE_APPROVAL as well?

[ryan-mchugh]

Need to check the WAITING_ON_CUSTOMER status

[ryan-mchugh]

Local Testing

SC User

Customer & SC

TOO User