Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B 22559 add filtering to rejected tab int #14938
base: integrationTesting
Are you sure you want to change the base?
B 22559 add filtering to rejected tab int #14938
Changes from 20 commits
d3f8d84
56c01a9
1210d4b
7ad4c72
38d8bd6
27cdcd5
8191575
29c9e8a
3ebb152
be8a59a
d13d25a
a7edba6
0b306db
b4649fb
14d6d15
5fb1be7
f5c9499
fe633a8
d76e361
abc6e63
a6fddd7
8f4f9d6
db4619b
e8dc583
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add backend test coverage for explicit checks on these cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Adding the tests ended up showing where I had holes so I updated some logic for the searches too. I'm holding off on asking for a rereview until I address all my pr comments.