-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAIN B-22668 #14945
Draft
danieljordan-caci
wants to merge
7
commits into
main
Choose a base branch
from
MAIN-B-22668
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
MAIN B-22668 #14945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger
Smaller No assets were smaller Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INT PR
Agility ticket
Feature Flag PR
Summary
We are rolling out customer self registration where we will have a little more control over form validations than we do in Okta. This PR specifically deals with the UI form, validations, and setting up feature flag work. No backend work involving the form submission or account creation is done in this BL.
This PR does the following:
customer_registration
feature flagStyledLine.jsx
,SignUp.jsx
,ValidCACModal.jsx
,RegistrationConfirmationModal.jsx
TextField.jsx
to not allow pasting when propdisablePaste
is providedHow to test
FEATURE_FLAG_CUSTOMER_REGISTRATION
in yourenvrc
server
&client
Sign up
button on the main page of the customer appSign up
againYes
on the CAC modalScreenshots
Desktop
https://github.com/user-attachments/assets/fcde2dee-026a-47e5-89a1-70a87513a69a
Mobile
https://github.com/user-attachments/assets/6f031975-bd9b-4e2a-a621-389b006890a7