-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B-22778 INT: Primary/Secondary GBLOCs for TOO Destination Queue #14951
base: integrationTesting
Are you sure you want to change the base?
Conversation
Bumps [store2](https://github.com/nbubna/store) from 2.14.2 to 2.14.4. - [Commits](nbubna/store@2.14.2...2.14.4) --- updated-dependencies: - dependency-name: store2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Main b 22039 remove lat lon
…2-2.14.4 Bump store2 from 2.14.2 to 2.14.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Also fixes the broken export so that can be marked OBE (probably) if @msaki-caci wants to verify
Thanks for testing! Is there a separate BL for the export? Agree it can probably be marked OBE since it was covered in the AC on this ticket, unless @msaki-caci's BL has more AC beyond what's on this |
|
Ah that one is in integration already so probably can't mark it as OBE and also doesn't hurt to have it around for testing! |
Maybe OBE isn't the right word, but they can no longer have the testing blocker once this is merged. My b. |
Sounds good! Thanks for letting me know that BL was a thing. Adding @msaki-caci to this PR too |
Agility ticket
Summary
Needed to add the primary/secondary GBLOC functionality to the destination queue.
How to test
Access the admin app
Make an office user with the TOO role with a primary and secondary GBLOC
Login as a customer
Make a move with zips in the primary GBLOC
Make a move with zips in the secondary GBLOC (postal_code_to_gblocs if you're unsure)
Log in as the office user you just created via the admin app
7.Counsel and approve both as the TOO
Add destination requests to both (destination SIT, destination shuttle, destination address request, pick your poison)
Go back to the TOO queue. You should be able to click on the GBLOC at the top of the page and toggle between primary and secondary
Go to the destination queue as the TOO
Toggle between primary and secondary GBLOCs, and ensure that you do not see the same moves when toggling back and forth. You should see the expected moves in the primary GBLOC and see the expected moves in the secondary GBLOC
Make sure you export to CSV and verify that you see the correct, distinct results for each GBLOC:

Run
go test ./pkg/services/order
Primary GBLOC of KKFA:

Secondary GBLOC of AGFM:
