B-20440 Uploaded document viewing improvements - Add Rotate and Save Ability for Image Files

[WeatherfordAaron]

implemented rotation and zoom capabilities for images

[danieljordan-caci]

Couple questions

[danieljordan-caci]

Is there any way to test this or is this just static code analysis for now?

[WeatherfordAaron]

Is there any way to test this or is this just static code analysis for now?

Well for right now, I think you can test it on integrationTesting.
But the independent testing stuff on the readme for this repo doesn't even work on main

[WeatherfordAaron]

I do see something else I probably need to change. In package.json, the version should step up, right? I believe the current way that the milmove app targets the v1.2.2 is from the tag that was added to the merge of "v1.2.2"... so I would probably need to add a tag of "v1.2.3" to this merge commit, I think as well

Alternatively, i could just remove the other v1.2.2 tag and make that tag be on this merge-commit

[danieljordan-caci]

I do see something else I probably need to change. In package.json, the version should step up, right? I believe the current way that the milmove app targets the v1.2.2 is from the tag that was added to the merge of "v1.2.2"... so I would probably need to add a tag of "v1.2.3" to this merge commit, I think as well

Alternatively, i could just remove the other v1.2.2 tag and make that tag be on this merge-commit

I believe this is correct, but I'll let @deandreJones or @cameroncaci chime in

I'll hold off approval until we hear back.

[deandreJones]

I do see something else I probably need to change. In package.json, the version should step up, right? I believe the current way that the milmove app targets the v1.2.2 is from the tag that was added to the merge of "v1.2.2"... so I would probably need to add a tag of "v1.2.3" to this merge commit, I think as well
Alternatively, i could just remove the other v1.2.2 tag and make that tag be on this merge-commit

I believe this is correct, but I'll let @deandreJones or @cameroncaci chime in

I'll hold off approval until we hear back.

if the tests prove successful, yes bump the version, then the corresponding mymove change should point to the new version

[WeatherfordAaron]

I do see something else I probably need to change. In package.json, the version should step up, right? I believe the current way that the milmove app targets the v1.2.2 is from the tag that was added to the merge of "v1.2.2"... so I would probably need to add a tag of "v1.2.3" to this merge commit, I think as well
Alternatively, i could just remove the other v1.2.2 tag and make that tag be on this merge-commit

I believe this is correct, but I'll let @deandreJones or @cameroncaci chime in
I'll hold off approval until we hear back.

if the tests prove successful, yes bump the version, then the corresponding mymove change should point to the new version

Sounds good. I bumped up the version in this package.json and after merge-commit goes into react-file-viewer main branch, I'll add that tag for the version.

[danieljordan-caci]

Able to rotate & save.

Kinda hate how you can't change the position of the view when zooming in (just kinda zooms in on center), but what can ya do. This meets the AC on the BL item.

Screen.Recording.2024-08-20.at.12.12.25.PM.mov

[WeatherfordAaron]

Able to rotate & save.

Kinda hate how you can't change the position of the view when zooming in (just kinda zooms in on center), but what can ya do. This meets the AC on the BL item.

Screen.Recording.2024-08-20.at.12.12.25.PM.mov

You can change position but you have to zoom in more. You would have to change position with scroll bars.. not ideal, I know.

@taeJungCaci found an issue where if you remove @transcom/react-file-viewer then git checkout package.json and then do a yarn install again, the controls disappear. If nobody has any suggestions as to why that happens, I'll be investigating now.