Skip to content
This repository was archived by the owner on Sep 23, 2024. It is now read-only.

Commit 24f877a

Browse files
committed
Clarify commented code
1 parent 43c8ab8 commit 24f877a

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

tap_postgres/sync_strategies/logical_replication.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,10 @@ def consume_message(streams, state, msg, time_extracted, conn_info, end_lsn):
302302
raise Exception("incorrectly attempting to flush an lsn({}) > end_lsn({})".format(msg.data_start, end_lsn))
303303

304304
# Flush Postgres log up to lsn received in current run
305-
# LOGGER.info("Sending feedback to server with flush_lsn = %s", msg.data_start)
305+
# This is the behaviour of the original tap-progres
306+
# The Pipelinewise version flushes only at the start of the next run
307+
# This is to ensure the data has been comitted on the destination
308+
# LOGGER.info("Sending flush_lsn = {} to source server".format(msg.data_start))
306309
# msg.cursor.send_feedback(flush_lsn=msg.data_start)
307310

308311
return state

0 commit comments

Comments
 (0)