address comments

Author: phbnf

cmd/aws/main.go

@@ -151,9 +151,9 @@ func newAWSStorage(ctx context.Context, signer note.Signer) (*storage.CTStorage,
 
 	var antispam tessera.Antispam
 	if *antispamDBName != "" {
-		antispam, err = aws_as.NewAntispam(ctx, antispamMysqlConfig().FormatDSN(), aws_as.AntispamOpts{})
+		antispam, err = aws_as.NewAntispam(ctx, antispamMySQLConfig().FormatDSN(), aws_as.AntispamOpts{})
 		if err != nil {
-			klog.Exitf("Failed to create new GCP antispam storage: %v", err)
+			klog.Exitf("Failed to create new AWS antispam storage: %v", err)
 		}
 	}
 
@@ -214,7 +214,7 @@ func storageConfigFromFlags() taws.Config {
 	if *dbUser == "" {
 		klog.Exit("--db_user must be set")
 	}
-	// Empty passord isn't an option with AuroraDB MySQL.
+	// Empty password isn't an option with AuroraDB MySQL.
 	if *dbPassword == "" {
 		klog.Exit("--db_password must be set")
 	}
@@ -237,7 +237,7 @@ func storageConfigFromFlags() taws.Config {
 	}
 }
 
-func antispamMysqlConfig() *mysql.Config {
+func antispamMySQLConfig() *mysql.Config {
 	if *antispamDBName == "" {
 		klog.Exit("--antispam_db_name must be set")
 	}

deployment/live/aws/test/README.md

@@ -67,7 +67,7 @@ export AWS_PROFILE=AdministratorAccess-<REDACTED>
 Terraforming the account can be done by:
   1. `cd` to [/deployment/live/aws/test/](/deployment/live/aws/test/) to deploy/change.
   2. Run `terragrunt apply`. If this fails to create the antispam database,
-  connect the RDS instance to your VM using the instrunctions bellow, and run
+  connect the RDS instance to your VM using the instructions below, and run
   `terragrunt apply` again.
 
 Store the Aurora RDS database and S3 bucket information into the environment variables:
@@ -99,7 +99,7 @@ go run ./cmd/aws \
   --db_port=3306 \
   --db_user=tesseract \
   --db_password=${TESSERACT_DB_PASSWORD} \
-  --antispam_db_name=antispam_db
+  --antispam_db_name=antispam_db \
   --signer_public_key_secret_name=${SCTFE_SIGNER_ECDSA_P256_PUBLIC_KEY_ID} \
   --signer_private_key_secret_name=${SCTFE_SIGNER_ECDSA_P256_PRIVATE_KEY_ID}
 ```
@@ -193,7 +193,7 @@ go run ./cmd/aws \
   --db_port=3306 \
   --db_user=tesseract \
   --db_password=${TESSERACT_DB_PASSWORD} \
-  --antispam_db_name=antispam_db
+  --antispam_db_name=antispam_db \
   --signer_public_key_secret_name=${SCTFE_SIGNER_ECDSA_P256_PUBLIC_KEY_ID} \
   --signer_private_key_secret_name=${SCTFE_SIGNER_ECDSA_P256_PRIVATE_KEY_ID}
   -v=3

deployment/modules/aws/storage/main.tf

@@ -59,7 +59,7 @@ data "aws_secretsmanager_secret_version" "db_credentials" {
 # creating the aws_db_instance.
 # This requires that the machine running terraform has access
 # to the DB instance created above. This is _NOT_ the case when
-# github actions are applying the terraform.
+# GitHub actions are applying the terraform.
 provider "mysql" {
   endpoint = aws_rds_cluster_instance.cluster_instances[0].endpoint
   username = aws_rds_cluster.log_rds_cluster.master_username

deployment/modules/gcp/storage/main.tf

@@ -78,8 +78,8 @@ resource "google_spanner_database" "antispam_db" {
   instance = google_spanner_instance.log_spanner.name
   name     = "${var.base_name}-antispam-db"
   ddl = [
-    	"CREATE TABLE IF NOT EXISTS FollowCoord (id INT64 NOT NULL, nextIdx INT64 NOT NULL) PRIMARY KEY (id)",
-			"CREATE TABLE IF NOT EXISTS IDSeq (h BYTES(32) NOT NULL, idx INT64 NOT NULL) PRIMARY KEY (h)",
+    "CREATE TABLE IF NOT EXISTS FollowCoord (id INT64 NOT NULL, nextIdx INT64 NOT NULL) PRIMARY KEY (id)",
+    "CREATE TABLE IF NOT EXISTS IDSeq (h BYTES(32) NOT NULL, idx INT64 NOT NULL) PRIMARY KEY (h)",
   ]
 
   deletion_protection = !var.ephemeral