comments

Author: phbnf

cmd/gcp/main.go

@@ -83,7 +83,7 @@ func main() {
 	}
 	cpSigner, err := sctfe.NewCpSigner(signer, *origin, timeSource)
 	if err != nil {
-		klog.Exitf("Failed to create checkpoint Signer: %v", err)
+		klog.Exitf("Failed to create checkpoint signer: %v", err)
 	}
 
 	storage, err := newGCPStorage(ctx, cpSigner)

config.go

@@ -79,7 +79,7 @@ func ValidateLogConfig(origin string, rootsPemFile string, rejectExpired bool, r
 
 	// Validate the time interval.
 	if notAfterStart != nil && notAfterLimit != nil && (notAfterLimit).Before(*notAfterStart) {
-		return nil, fmt.Errorf("not_after limit %q before start %q", notAfterLimit.Format(time.RFC3339), notAfterStart.Format(time.RFC3339))
+		return nil, fmt.Errorf("'Not After' limit %q before start %q", notAfterLimit.Format(time.RFC3339), notAfterStart.Format(time.RFC3339))
 	}
 
 	validationOpts := CertValidationOpts{

handlers_test.go

@@ -400,7 +400,7 @@ func TestAddChain(t *testing.T) {
 				}
 				// TODO(phboneff): check that the index is in the SCT
 				// TODO(phboneff): add a test with a not after range
-				// TODO(phbpneff): add a test with a start date only
+				// TODO(phboneff): add a test with a start date only
 			}
 		})
 	}
@@ -447,7 +447,7 @@ func TestAddPrechain(t *testing.T) {
 		// TODO(phboneff): add a test with an intermediate
 		// TODO(phboneff): add a test with a pre-issuer intermediate cert
 		// TODO(phboneff): add a test with a not after range
-		// TODO(phbpneff): add a test with a start date only
+		// TODO(phboneff): add a test with a start date only
 	}
 
 	signer, err := setupSigner(fakeSignature)