Skip to content

Commit 4368a46

Browse files
committed
nits
1 parent 00733ac commit 4368a46

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

deployment/live/gcp/static-ct-staging/cloudbuild/preloader/terragrunt.hcl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,3 @@ remote_state {
3030
}
3131
}
3232
}
33-

deployment/modules/gcp/cloudbuild/preloader/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ resource "google_cloudbuild_trigger" "preloader_trigger" {
9595
}
9696
}
9797

98+
// TODO(phboneff): replace with a long running job once the log is public.
9899
resource "google_cloud_scheduler_job" "deploy_cron" {
99100
paused = false
100101
project = var.project_id
@@ -106,7 +107,6 @@ resource "google_cloud_scheduler_job" "deploy_cron" {
106107

107108
attempt_deadline = "120s"
108109

109-
// TODO(phboneff): use a batch job instead maybe
110110
http_target {
111111
http_method = "POST"
112112
uri = "https://cloudbuild.googleapis.com/v1/projects/${var.project_id}/locations/${var.location}/triggers/${google_cloudbuild_trigger.preloader_trigger.trigger_id}:run"

deployment/modules/gcp/cloudbuild/preloader/variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,4 +36,4 @@ variable "monitoring_url" {
3636
variable "source_log_uri" {
3737
description = "URL of the source RFC6962 log"
3838
type = string
39-
}
39+
}

0 commit comments

Comments
 (0)