Skip to content

Commit 55dae5a

Browse files
committed
add extension in relevant tests
1 parent c3a9783 commit 55dae5a

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

internal/scti/signatures_test.go

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ var (
3535
fixedTime = time.Date(2017, 9, 7, 12, 15, 23, 0, time.UTC)
3636
fixedTimeMillis = uint64(fixedTime.UnixNano() / nanosPerMilli)
3737
demoLogID = [32]byte{19, 56, 222, 93, 229, 36, 102, 128, 227, 214, 3, 121, 93, 175, 126, 236, 97, 217, 34, 32, 40, 233, 98, 27, 46, 179, 164, 251, 84, 10, 60, 57}
38+
fakeIndex = uint8(8)
39+
fakeExtension = []byte{0, 0, 5, 0, 0, 0, 0, fakeIndex}
3840
fakeSignature = []byte("signed")
3941
)
4042

@@ -81,7 +83,6 @@ const (
8183
// tbs certificate, 3 bytes
8284
"746273" +
8385
// extensions length, 2 bytes
84-
// TODO(phboneff)
8586
"0000" +
8687
// extensions, 0 bytes
8788
""
@@ -259,7 +260,7 @@ func TestBuildV1MerkleTreeLeafForCert(t *testing.T) {
259260
t.Fatalf("buildV1MerkleTreeLeafForCert()=nil,%v; want _,nil", err)
260261
}
261262
var leaf types.MerkleTreeLeaf
262-
leafValue := entry.MerkleTreeLeaf(0)
263+
leafValue := entry.MerkleTreeLeaf(uint64(fakeIndex))
263264
if rest, err := tls.Unmarshal(leafValue, &leaf); err != nil {
264265
t.Fatalf("failed to reconstruct MerkleTreeLeaf: %s", err)
265266
} else if len(rest) > 0 {
@@ -274,8 +275,7 @@ func TestBuildV1MerkleTreeLeafForCert(t *testing.T) {
274275
SCTVersion: 0,
275276
LogID: types.LogID{KeyID: demoLogID},
276277
Timestamp: fixedTimeMillis,
277-
// TODO(phboneff): add extension
278-
Extensions: types.CTExtensions{},
278+
Extensions: types.CTExtensions(fakeExtension),
279279
Signature: types.DigitallySigned{
280280
Algorithm: tls.SignatureAndHashAlgorithm{
281281
Hash: tls.SHA256,
@@ -323,7 +323,7 @@ func TestSignV1SCTForPrecertificate(t *testing.T) {
323323
t.Fatalf("buildV1MerkleTreeLeafForCert()=nil,%v; want _,nil", err)
324324
}
325325
var leaf types.MerkleTreeLeaf
326-
leafValue := entry.MerkleTreeLeaf(0)
326+
leafValue := entry.MerkleTreeLeaf(uint64(fakeIndex))
327327
if rest, err := tls.Unmarshal(leafValue, &leaf); err != nil {
328328
t.Fatalf("failed to reconstruct MerkleTreeLeaf: %s", err)
329329
} else if len(rest) > 0 {
@@ -339,8 +339,7 @@ func TestSignV1SCTForPrecertificate(t *testing.T) {
339339
SCTVersion: 0,
340340
LogID: types.LogID{KeyID: demoLogID},
341341
Timestamp: fixedTimeMillis,
342-
// TODO(phboneff): add extension
343-
Extensions: types.CTExtensions{},
342+
Extensions: types.CTExtensions(fakeExtension),
344343
Signature: types.DigitallySigned{
345344
Algorithm: tls.SignatureAndHashAlgorithm{
346345
Hash: tls.SHA256,

0 commit comments

Comments
 (0)