add extension in relevant tests

Author: phbnf

internal/scti/signatures_test.go

@@ -35,6 +35,8 @@ var (
 	fixedTime       = time.Date(2017, 9, 7, 12, 15, 23, 0, time.UTC)
 	fixedTimeMillis = uint64(fixedTime.UnixNano() / nanosPerMilli)
 	demoLogID       = [32]byte{19, 56, 222, 93, 229, 36, 102, 128, 227, 214, 3, 121, 93, 175, 126, 236, 97, 217, 34, 32, 40, 233, 98, 27, 46, 179, 164, 251, 84, 10, 60, 57}
+	fakeIndex       = uint8(8)
+	fakeExtension   = []byte{0, 0, 5, 0, 0, 0, 0, fakeIndex}
 	fakeSignature   = []byte("signed")
 )
 
@@ -81,7 +83,6 @@ const (
 		// tbs certificate, 3 bytes
 		"746273" +
 		// extensions length, 2 bytes
-		// TODO(phboneff)
 		"0000" +
 		// extensions, 0 bytes
 		""
@@ -259,7 +260,7 @@ func TestBuildV1MerkleTreeLeafForCert(t *testing.T) {
 		t.Fatalf("buildV1MerkleTreeLeafForCert()=nil,%v; want _,nil", err)
 	}
 	var leaf types.MerkleTreeLeaf
-	leafValue := entry.MerkleTreeLeaf(0)
+	leafValue := entry.MerkleTreeLeaf(uint64(fakeIndex))
 	if rest, err := tls.Unmarshal(leafValue, &leaf); err != nil {
 		t.Fatalf("failed to reconstruct MerkleTreeLeaf: %s", err)
 	} else if len(rest) > 0 {
@@ -274,8 +275,7 @@ func TestBuildV1MerkleTreeLeafForCert(t *testing.T) {
 		SCTVersion: 0,
 		LogID:      types.LogID{KeyID: demoLogID},
 		Timestamp:  fixedTimeMillis,
-		// TODO(phboneff): add extension
-		Extensions: types.CTExtensions{},
+		Extensions: types.CTExtensions(fakeExtension),
 		Signature: types.DigitallySigned{
 			Algorithm: tls.SignatureAndHashAlgorithm{
 				Hash:      tls.SHA256,
@@ -323,7 +323,7 @@ func TestSignV1SCTForPrecertificate(t *testing.T) {
 		t.Fatalf("buildV1MerkleTreeLeafForCert()=nil,%v; want _,nil", err)
 	}
 	var leaf types.MerkleTreeLeaf
-	leafValue := entry.MerkleTreeLeaf(0)
+	leafValue := entry.MerkleTreeLeaf(uint64(fakeIndex))
 	if rest, err := tls.Unmarshal(leafValue, &leaf); err != nil {
 		t.Fatalf("failed to reconstruct MerkleTreeLeaf: %s", err)
 	} else if len(rest) > 0 {
@@ -339,8 +339,7 @@ func TestSignV1SCTForPrecertificate(t *testing.T) {
 		SCTVersion: 0,
 		LogID:      types.LogID{KeyID: demoLogID},
 		Timestamp:  fixedTimeMillis,
-		// TODO(phboneff): add extension
-		Extensions: types.CTExtensions{},
+		Extensions: types.CTExtensions(fakeExtension),
 		Signature: types.DigitallySigned{
 			Algorithm: tls.SignatureAndHashAlgorithm{
 				Hash:      tls.SHA256,