Simplify for loop with slices.Contains (#171)

Author: roger2hk

internal/hammer/loadtest/workers.go

@@ -24,6 +24,8 @@ import (
 	"math/rand/v2"
 	"time"
 
+	"slices"
+
 	"github.com/google/certificate-transparency-go/x509"
 	"github.com/transparency-dev/formats/log"
 	"github.com/transparency-dev/merkle/proof"
@@ -455,10 +457,5 @@ func entryFromChain(chain []*x509.Certificate, isPrecert bool, timestamp uint64)
 // certificate transparency extended key usage.
 // Copied from certificate-transparency-go/serialization.go and internal/scti/handlers.go.
 func isPreIssuer(issuer *x509.Certificate) bool {
-	for _, eku := range issuer.ExtKeyUsage {
-		if eku == x509.ExtKeyUsageCertificateTransparency {
-			return true
-		}
-	}
-	return false
+	return slices.Contains(issuer.ExtKeyUsage, x509.ExtKeyUsageCertificateTransparency)
 }

internal/scti/handlers.go

@@ -28,6 +28,8 @@ import (
 	"sync"
 	"time"
 
+	"slices"
+
 	"github.com/google/certificate-transparency-go/tls"
 	"github.com/google/certificate-transparency-go/x509"
 	"github.com/prometheus/client_golang/prometheus"
@@ -510,10 +512,5 @@ func entryFromChain(chain []*x509.Certificate, isPrecert bool, timestamp uint64)
 // certificate transparency extended key usage.
 // copied form certificate-transparency-go/serialization.go
 func isPreIssuer(issuer *x509.Certificate) bool {
-	for _, eku := range issuer.ExtKeyUsage {
-		if eku == x509.ExtKeyUsageCertificateTransparency {
-			return true
-		}
-	}
-	return false
+	return slices.Contains(issuer.ExtKeyUsage, x509.ExtKeyUsageCertificateTransparency)
 }