Skip to content

Commit abd318b

Browse files
authored
Panic if inclusion proof is failed in MMD verifiers (#175)
1 parent f80db53 commit abd318b

File tree

1 file changed

+6
-17
lines changed

1 file changed

+6
-17
lines changed

internal/hammer/loadtest/workers.go

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -348,37 +348,26 @@ func (v *MMDVerifier) Run(ctx context.Context) {
348348
Hash: checkpoint.Hash,
349349
}, v.tracker.TileFetcher)
350350
if err != nil {
351-
v.errChan <- fmt.Errorf("failed to create proof builder: %w", err)
352-
leafMMD = nil
353-
continue
351+
panic(fmt.Sprintf("Failed to create proof builder: %v", err))
354352
}
355353
}
356354

357-
// TODO: Exit gracefully with error code when the following logic hits
358-
// any error.
355+
// Panic if the following logic hits any error.
359356
ip, err := proofBuilder.InclusionProof(ctx, leafMMD.index)
360357
if err != nil {
361-
v.errChan <- fmt.Errorf("failed to create inclusion proof: %w", err)
362-
leafMMD = nil
363-
continue
358+
panic(fmt.Sprintf("Failed to create inclusion proof: %v", err))
364359
}
365360
certs, err := x509.ParseCertificates(leafMMD.leaf)
366361
if err != nil {
367-
v.errChan <- fmt.Errorf("failed to parse certificates: %w", err)
368-
leafMMD = nil
369-
continue
362+
panic(fmt.Sprintf("Failed to parse certificates: %v", err))
370363
}
371364
entry, err := entryFromChain(certs, false, leafMMD.timestamp)
372365
if err != nil {
373-
v.errChan <- fmt.Errorf("failed to create entry from chain: %w", err)
374-
leafMMD = nil
375-
continue
366+
panic(fmt.Sprintf("Failed to create entry from chain: %v", err))
376367
}
377368
leafHash := entry.MerkleLeafHash(leafMMD.index)
378369
if err := proof.VerifyInclusion(rfc6962.DefaultHasher, leafMMD.index, checkpoint.Size, leafHash, ip, checkpoint.Hash); err != nil {
379-
v.errChan <- fmt.Errorf("failed to verify inclusion proof: %w", err)
380-
leafMMD = nil
381-
continue
370+
panic(fmt.Sprintf("Failed to verify inclusion proof: %v", err))
382371
}
383372

384373
leafMMD = nil

0 commit comments

Comments
 (0)