Update internal/ct/handlers.go

phbnf · roger2hk · web-flow · commit af0ebbff1b9c · 2025-05-19T17:55:12.000+01:00
Co-authored-by: Roger Ng &lt;roger2hk@gmail.com&gt;
diff --git a/internal/ct/handlers.go b/internal/ct/handlers.go
@@ -287,11 +287,8 @@ func addChainInternal(ctx context.Context, opts *HandlerOptions, log *log, w htt
 		}
 		return http.StatusInternalServerError, nil, fmt.Errorf("couldn't store the leaf: %v", err)
 	}
-	dedupedAttribute := duplicateKey.Bool(false)
 	isDup := dedupedTimeMillis != timeMillis
-	if isDup {
-		dedupedAttribute = duplicateKey.Bool(true)
-	}
+	dedupedAttribute := duplicateKey.Bool(isDup)
 	entry.Timestamp = dedupedTimeMillis
 
 	// Always use the returned leaf as the basis for an SCT.

Original file line number	Diff line number	Diff line change
`@@ -287,11 +287,8 @@ func addChainInternal(ctx context.Context, opts HandlerOptions, log log, w htt`
`287`	`287`	`}`
`288`	`288`	`return http.StatusInternalServerError, nil, fmt.Errorf("couldn't store the leaf: %v", err)`
`289`	`289`	`}`
`290`		`- dedupedAttribute := duplicateKey.Bool(false)`
`291`	`290`	`isDup := dedupedTimeMillis != timeMillis`
`292`		`- if isDup {`
`293`		`- dedupedAttribute = duplicateKey.Bool(true)`
`294`		`- }`
	`291`	`+ dedupedAttribute := duplicateKey.Bool(isDup)`
`295`	`292`	`entry.Timestamp = dedupedTimeMillis`
`296`	`293`
`297`	`294`	`// Always use the returned leaf as the basis for an SCT.`