address more comments

Author: phbnf

internal/scti/handlers_test.go

@@ -79,7 +79,7 @@ func (f *fixedTimeSource) Now() time.Time {
 	return f.fakeTime
 }
 
-// setupTestLog creates test TesseraCT log using a POSIX backend.
+// setupTestLog creates a test TesseraCT log using a POSIX backend.
 func setupTestLog(t *testing.T) *log {
 	t.Helper()
 
@@ -90,7 +90,7 @@ func setupTestLog(t *testing.T) *log {
 
 	roots := x509util.NewPEMCertPool()
 	if err := roots.AppendCertsFromPEMFile(testRootPath); err != nil {
-		t.Fatalf("failed to read trusted roots: %v", err)
+		t.Fatalf("Failed to read trusted roots: %v", err)
 	}
 
 	cvOpts := ChainValidationOpts{

internal/testonly/storage/posix/issuers.go

@@ -52,7 +52,7 @@ func (s IssuersStorage) keyToObjName(key []byte) (string, error) {
 	if string(key) == "" {
 		return "", fmt.Errorf("key cannot be empty")
 	}
-	if strings.Contains(string(key), "/") {
+	if strings.Contains(string(key), string(os.PathSeparator)) {
 		return "", fmt.Errorf("key %q cannot contain '/'", string(key))
 	}
 	return path.Join(string(s), string(key)), nil

internal/testonly/storage/posix/issuers_test.go

@@ -16,6 +16,7 @@ package posix
 
 import (
 	"context"
+	"fmt"
 	"os"
 	"path/filepath"
 	"reflect"
@@ -77,14 +78,14 @@ func TestKeyToObjName(t *testing.T) {
 			wantErr: true,
 		},
 		{
-			name:    "key with slash",
-			key:     []byte("issuer/1"),
+			name:    "key with os.PathSeparator",
+			key:     []byte(fmt.Sprintf("issuer%s1", string(os.PathSeparator))),
 			want:    "",
 			wantErr: true,
 		},
 		{
 			name:    "key with multiple slashes",
-			key:     []byte("issuer/1/2"),
+			key:     []byte(fmt.Sprintf("issuer%s1%s2", string(os.PathSeparator), string(os.PathSeparator))),
 			want:    "",
 			wantErr: true,
 		},