Drop dependency on trillian/monitoring #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # internal/scti/handlers_test.go # Conflicts: # internal/scti/handlers.go
# Conflicts: # internal/scti/handlers.go # Conflicts: # internal/scti/handlers.go
AlCutter
approved these changes
Feb 10, 2025
| reqsCounter monitoring.Counter // origin, ep => value | ||
| rspsCounter monitoring.Counter // origin, ep, rc => value | ||
| rspLatency monitoring.Histogram // origin, ep, rc => value | ||
| knownLogs *prometheus.GaugeVec // origin => value (always 1.0) |
There was a problem hiding this comment.
Could just remove this one, I suspect?
There was a problem hiding this comment.
I've left it on purpose: this will allow to build global dashboard with all the log names for instance, if multiple stacks exist. It's a nice way to extract the origin, and protects us from bugs like nan values on some metrics because no request is flying around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #105 and #106
This PR makes use of the prometheus library directly, rather than using trillian/monitoring.
It also introduces the following changes:
lastSCTIndexmetric since SCTs now include an indexlogidlabel toorigineplabel toop