Add wrong signer type and empty signer test cases into TestNewLog
#182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhutchinson
reviewed
Mar 13, 2025
| "strings" | ||
| "testing" | ||
|
|
||
| "github.com/google/trillian/crypto/keys/pem" | ||
| trillianpem "github.com/google/trillian/crypto/keys/pem" |
There was a problem hiding this comment.
I thought you were trying to remove dependencies on trillian from TesseraCT?
There was a problem hiding this comment.
Correct. This pull request needs the "encoding/pem" module, so there is a name clash. I will remove the "github.com/google/trillian/crypto/keys/pem" dependency in the another pull request. Created #183 to track.
mhutchinson
approved these changes
Mar 13, 2025
Let me merge these two methods into one in the next pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #103.