Skip to content

arche2025h1 configs #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 26, 2025
Merged

arche2025h1 configs #211

merged 12 commits into from
Mar 26, 2025

Conversation

phbnf
Copy link
Collaborator

@phbnf phbnf commented Mar 24, 2025

Towards #104

This PR introduces arche2025h1 log config. It's not an end state, but reflects how I've been running it for some time now, so let's get this in.

Another PR will configure the preloader, I thought I'd split them in two for ease of reviewing. Some part of this current PR might mention the preloader, because it's coming in the PR just after.

This PR:

  • introduces's arche2025h1 terraform and terragrunt configs: configs in this PR are based on pre-existing configs, with some minor differences that you can see in invidivual prs.
  • defines arche2025h1's roots, and explains how to update them. We ought to be something better later, but it's okay for now.
  • triggers a log deployment each time we tag a commit with "deploy-staging-XX" to make development faster for now

@phbnf phbnf requested a review from roger2hk March 24, 2025 14:13
@phbnf phbnf marked this pull request as ready for review March 24, 2025 14:19
Copy link
Contributor

@roger2hk roger2hk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the static-ct-staging directory to deployment/live/gcp/README.md.

Comment on lines +5 to +6
locals {
env = path_relative_to_include()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it likely to have another env under the static-ct-staging directory? Consider merging this file with deployment/live/gcp/static-ct-staging/cloudbuild/staging/terragrunt.hcl?

Copy link
Collaborator Author

@phbnf phbnf Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes agreed that can be changed - I paused here, but I'm actively thinking about changing this, and maybe having a cloudbuild for the log, and a different one to run the preloader. I'll leave things like this for now, to make sure they mirror the static-ct setup.

This GCP SCTFE preloaded staging environment is designed to be deployed by the Cloud Build ([Terraform module](/deployment/modules/gcp/cloudbuild/preloaded/), [Terragrunt configuration](/deployment/live/gcp/static-ct-staging/cloudbuild/staging/)).

### Manual Deployment
TODO(phboneff): come back to this, CloudRun doesn't trigger a deployment if the tag value change value.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TODO(phboneff): come back to this, CloudRun doesn't trigger a deployment if the tag value change value.
TODO(phboneff): come back to this, Cloud Run doesn't trigger a deployment if the tag value change value.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean the tag is re-tagged to another commit and force pushed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't parse my own sentence, sorry. If a Cloud Run service was started via terraform with a container tagged with "latest", a new (different!) container is tagged "latest", and the terraform config is applied again, the Cloud Run service won't restart. A fix is to use tags that are non stable across containers, such as their SHORT_HASH. It's not an issue for the ci stack, because we bring it down and up every time.

@phbnf phbnf merged commit ad6964b into transparency-dev:main Mar 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants