-
Notifications
You must be signed in to change notification settings - Fork 6
arche2025h1 configs #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arche2025h1 configs #211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the static-ct-staging
directory to deployment/live/gcp/README.md
.
locals { | ||
env = path_relative_to_include() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it likely to have another env
under the static-ct-staging
directory? Consider merging this file with deployment/live/gcp/static-ct-staging/cloudbuild/staging/terragrunt.hcl?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes agreed that can be changed - I paused here, but I'm actively thinking about changing this, and maybe having a cloudbuild for the log, and a different one to run the preloader. I'll leave things like this for now, to make sure they mirror the static-ct
setup.
deployment/live/gcp/static-ct-staging/logs/arche2025h1/README.md
Outdated
Show resolved
Hide resolved
deployment/live/gcp/static-ct-staging/logs/arche2025h1/README.md
Outdated
Show resolved
Hide resolved
This GCP SCTFE preloaded staging environment is designed to be deployed by the Cloud Build ([Terraform module](/deployment/modules/gcp/cloudbuild/preloaded/), [Terragrunt configuration](/deployment/live/gcp/static-ct-staging/cloudbuild/staging/)). | ||
|
||
### Manual Deployment | ||
TODO(phboneff): come back to this, CloudRun doesn't trigger a deployment if the tag value change value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO(phboneff): come back to this, CloudRun doesn't trigger a deployment if the tag value change value. | |
TODO(phboneff): come back to this, Cloud Run doesn't trigger a deployment if the tag value change value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean the tag is re-tagged to another commit and force pushed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't parse my own sentence, sorry. If a Cloud Run service was started via terraform with a container tagged with "latest", a new (different!) container is tagged "latest", and the terraform config is applied again, the Cloud Run service won't restart. A fix is to use tags that are non stable across containers, such as their SHORT_HASH. It's not an issue for the ci stack, because we bring it down and up every time.
Towards #104
This PR introduces arche2025h1 log config. It's not an end state, but reflects how I've been running it for some time now, so let's get this in.
Another PR will configure the preloader, I thought I'd split them in two for ease of reviewing. Some part of this current PR might mention the preloader, because it's coming in the PR just after.
This PR: