Update certificates used in handlers_test.go #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roger2hk
approved these changes
Mar 26, 2025
internal/testdata/certificates.go
Outdated
| @@ -287,6 +287,160 @@ var PreCertFromPreIntermediate string | |||
|
|
|||
| // Issuance chain 3 | |||
| // ================ | |||
| // The next section holds: | |||
| // - an intermediate with signed with the root above. | |||
There was a problem hiding this comment.
Suggested change
| // - an intermediate with signed with the root above. | |
| // - an intermediate signed with the root above. |
internal/testdata/gen/gen.go
Outdated
| } | ||
| leafPreCert, err := chainGenerator.certificate(200, true, notBefore) | ||
| if err != nil { | ||
| klog.Fatalf("Failed to generate leaf certificate: %v", err) |
There was a problem hiding this comment.
Suggested change
| klog.Fatalf("Failed to generate leaf certificate: %v", err) | |
| klog.Fatalf("Failed to generate leaf pre-certificate: %v", err) |
internal/testdata/gen/gen.go
Outdated
| klog.Fatalf("Failed to generate leaf certificate: %v", err) | ||
| } | ||
| if err := saveCertificatePEM(leafPreCert, path.Join(*outputPath, "test_leaf_pre_cert_signed_by_intermediate.pem")); err != nil { | ||
| klog.Fatalf("Failed to save leaf cert: %v", err) |
There was a problem hiding this comment.
Suggested change
| klog.Fatalf("Failed to save leaf cert: %v", err) | |
| klog.Fatalf("Failed to save leaf pre-cert: %v", err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #103, #217.
This PR:
gen.gohandlers_test.go, rather than a different chain, thus ensuring that all chains in this file chain up to the same rootTestAddChainWhitespacerequests programmatically rather than hardcoding them.