Skip to content

[AWS] Extract tls_private_key resource from hashicorp/tls provider into an insecure module #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

roger2hk
Copy link
Contributor

@roger2hk roger2hk commented Mar 26, 2025

Towards #109, #219.

This PR reorganized the resources. terragrunt apply will regenerate the public and private keys and store them in the same secret resource IDs.

@roger2hk roger2hk requested a review from phbnf March 26, 2025 17:53
@roger2hk roger2hk changed the title Extract tls_private_key resource from hashicorp/tls provider into an insecure module [AWS] Extract tls_private_key resource from hashicorp/tls provider into an insecure module Mar 26, 2025
Copy link
Collaborator

@AlCutter AlCutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm far from being a terraform expert, but am I right in thinking that this PR doesn't change anything about what's stored in the state, it's mainly just about making it clear that it's currently doing things which you wouldn't want to do in prod?

@roger2hk
Copy link
Contributor Author

I'm far from being a terraform expert, but am I right in thinking that this PR doesn't change anything about what's stored in the state, it's mainly just about making it clear that it's currently doing things which you wouldn't want to do in prod?

This PR reorganized the resources. terragrunt apply will regenerate the public and private keys and store them in the same secret resource IDs.

This is fine for AWS. For GCP, the staging log arche2025h1 would be affected by the auto deployment. A manual deployment is required. It's probably a good chance to run the Manual Deployment playbook.

@roger2hk roger2hk merged commit 11867bf into transparency-dev:main Apr 2, 2025
7 checks passed
@roger2hk roger2hk deleted the extract-insecure-tf-resource branch April 2, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants