Move parser into staticct.go #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roger2hk
approved these changes
Apr 7, 2025
AlCutter
approved these changes
Apr 7, 2025
internal/types/staticct/staticct.go
Outdated
| @@ -102,3 +103,45 @@ func (t *EntryBundle) UnmarshalText(raw []byte) error { | |||
| t.Entries = entries | |||
| return nil | |||
| } | |||
|
|
|||
| // parseCTExtensions parses CTEXtensions into an index. | |||
There was a problem hiding this comment.
Suggested change
| // parseCTExtensions parses CTEXtensions into an index. | |
| // parseCTExtensions parses CTExtensions into an index. |
internal/types/staticct/staticct.go
Outdated
| extensions := cryptobyte.String(extensionBytes) | ||
| var extensionType uint8 | ||
| var extensionData cryptobyte.String | ||
| var leafIdx int64 |
There was a problem hiding this comment.
nit: this can't be -ve
Suggested change
| var leafIdx int64 | |
| var leafIdx uint64 |
internal/types/staticct/staticct.go
Outdated
| } | ||
| if !extensionData.Empty() || | ||
| !extensions.Empty() { | ||
| return 0, fmt.Errorf("invalid data tile extensions: %v", ext) |
There was a problem hiding this comment.
Suggested change
| return 0, fmt.Errorf("invalid data tile extensions: %v", ext) | |
| return 0, fmt.Errorf("invalid SCT extension data: %v", ext) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I'm there, rename staticctapi.go to staticct.go, I forgot to do this in the previous PR.